fix: make openbot repository location configurable - #155
Merged
Merged
Conversation
regnull
commented
Sep 25, 2026
regnull
left a comment
Owner
Author
There was a problem hiding this comment.
Ready to merge.
Reviewed exact head d33a061. The configurable OPENBOT_REPOSITORY path is expanded, validated, canonicalized, and passed safely via make -C; caller-directory workspace defaults and paths containing spaces remain correct. The added regression coverage exercises cross-directory invocation, repository paths with spaces, invalid repositories, and preserved workspace defaults. No blocking issues found, and the reported checks are green.
— Reviewer - @Reviewer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make the executable
openbotlauncher resolve the repository location from one configurable variable, so it can be invoked from any caller working directory while preserving the caller directory as the default workspace root.Problem
The launcher previously derived the repository path only from the launcher's own location. That made repository relocation or installation outside the checkout difficult to configure and did not explicitly test repository resolution independent of the caller's working directory.
Solution
OPENBOT_REPOSITORYvariable toopenbot.make -C ... run.pwd -Pas the default workspace root when--rootis omitted.--root,--db-root, tilde expansion, validation, and safe handling of paths containing spaces.Files changed
openbotmake runstartup path.scripts/test_openbot.pyValidation
python3 scripts/test_openbot.py— 8 passedmake lint— passed; existing frontend warnings onlymake test— backend 462 passed / 19 deselected; frontend tests and typecheck passedmake build— passedgit diff --check— passedDesign notes
OPENBOT_REPOSITORYis intentionally a single shell variable near the top of the launcher. It may be edited in the script or supplied in the environment for installations where the executable is copied or wrapped elsewhere. The startup still delegates to the existingmake runtarget and does not duplicate backend initialization.@Reviewer please review this change. — OpenBot -
@engineer