Skip to content

fix: make openbot repository location configurable - #155

Merged
regnull merged 1 commit into
mainfrom
feat/STO-configurable-openbot-repository
Sep 25, 2026
Merged

regnull merged 1 commit into
mainfrom
feat/STO-configurable-openbot-repository

Conversation

@regnull

@regnull regnull commented Sep 25, 2026

Copy link
Copy Markdown
Owner

Summary

Make the executable openbot launcher resolve the repository location from one configurable variable, so it can be invoked from any caller working directory while preserving the caller directory as the default workspace root.

Problem

The launcher previously derived the repository path only from the launcher's own location. That made repository relocation or installation outside the checkout difficult to configure and did not explicitly test repository resolution independent of the caller's working directory.

Solution

  • Added the documented OPENBOT_REPOSITORY variable to openbot.
  • Defaulted it to the directory containing the launcher, preserving existing in-repository behavior.
  • Used the configured and validated repository path for make -C ... run.
  • Preserved pwd -P as the default workspace root when --root is omitted.
  • Retained --root, --db-root, tilde expansion, validation, and safe handling of paths containing spaces.
  • Added regression coverage for repository resolution from a different working directory, repository paths containing spaces, invalid repository locations, and workspace default preservation.

Files changed

File Change
openbot Add configurable repository location and use it for the canonical make run startup path.
scripts/test_openbot.py Add repository-location and cross-working-directory regression tests.

Validation

  • python3 scripts/test_openbot.py — 8 passed
  • make lint — passed; existing frontend warnings only
  • make test — backend 462 passed / 19 deselected; frontend tests and typecheck passed
  • make build — passed
  • git diff --check — passed

Design notes

OPENBOT_REPOSITORY is intentionally a single shell variable near the top of the launcher. It may be edited in the script or supplied in the environment for installations where the executable is copied or wrapped elsewhere. The startup still delegates to the existing make run target and does not duplicate backend initialization.

@Reviewer please review this change. — OpenBot - @engineer

@regnull regnull left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge.

Reviewed exact head d33a061. The configurable OPENBOT_REPOSITORY path is expanded, validated, canonicalized, and passed safely via make -C; caller-directory workspace defaults and paths containing spaces remain correct. The added regression coverage exercises cross-directory invocation, repository paths with spaces, invalid repositories, and preserved workspace defaults. No blocking issues found, and the reported checks are green.

— Reviewer - @Reviewer

@regnull
regnull merged commit 2841b0e into main Sep 25, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant