fix: add timeout to nwc makeHoldInvoice

[frnandu]

Summary by CodeRabbit

• Enhancements
  • Added an optional timeout setting for hold invoice requests.
  • Callers can now extend or reduce the request duration instead of relying on the default timeout.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: a986f2e9-46e8-4c12-b1fc-b7f5d3a3de26

📥 Commits

Reviewing files that changed from the base of the PR and between 38e50aa and c7b3ffb.

📒 Files selected for processing (1)

• packages/ndk/lib/domain_layer/usecases/nwc/nwc.dart

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

---

📝 Walkthrough

Walkthrough

makeHoldInvoice now accepts an optional timeout parameter and forwards it to _executeRequest. Callers can override the default request timeout for hold invoice operations.

Changes

Hold Invoice Timeout

Layer / File(s)	Summary
Forward hold invoice timeout packages/ndk/lib/domain_layer/usecases/nwc/nwc.dart	makeHoldInvoice accepts an optional Duration? timeout and passes it to _executeRequest.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to c7b3f

This localized timeout change presents no actionable merge-blocking risk at the current head and is merge-ready after normal checks and review.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the added timeout support for NWC makeHoldInvoice.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/nwc-make-hold-invoice-timeout

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.66%. Comparing base (5a8cf9c) to head (c7b3ffb).
⚠️ Report is 6 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #738      +/-   ##
==========================================
- Coverage   72.44%   71.66%   -0.78%     
==========================================
  Files         227      227              
  Lines       13338    13338              
==========================================
- Hits         9663     9559     -104     
- Misses       3675     3779     +104     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.