fix Use field defaults from schema in v1 - #269
Open
danielcardoso5 wants to merge 5 commits into
Open
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 04472f1. Configure here.
dragidavid
approved these changes
Aug 18, 2026
Collaborator
|
Sorry for the delay @danielcardoso5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes default values not being taken into account when initializing a form like v0 did. Supports passing default values for base fields, nested fields and group-array items.
With the schema from #249:
Note
Medium Risk
Changes initial form state and conditional visibility for all consumers relying on missing defaults; behavior differs from v0 for explicit falsy initial values.
Overview
Restores v0-style default seeding so
createHeadlessFormapplies JSON Schemadefaultvalues before the first field build, fixing conditionals (e.g.if/then) that depend on a defaulted field not resolving until afterhandleValidation.A new
fillDefaultshelper walks the base schema: object properties, nested objects, and existing array items only. It setsdefaultwhen the value isundefined—explicit falsy values likenullare kept (documented as a v0 vs v1 migration difference). Defaults inside conditional sub-schemas are not applied.initialValuesare not mutated.MIGRATING.md adds a breaking-change note on default semantics; tests cover init-time conditionals, overrides, nested and group-array cases.
Reviewed by Cursor Bugbot for commit c9f151d. Bugbot is set up for automated code reviews on this repo. Configure here.