feat(components): Add customization support for ZendeskTriggerButton component - #1262
Open
gabrielremote wants to merge 12 commits into
Open
feat(components): Add customization support for ZendeskTriggerButton component#1262gabrielremote wants to merge 12 commits into
gabrielremote wants to merge 12 commits into
Conversation
Add example implementation showing how to customize the Zendesk trigger button component with custom styling. Co-authored-by: gabrielremote <gabrielremote@users.noreply.github.com>
- Add ZendeskTriggerButtonComponentProps type - Add zendeskTriggerButton to Components type - Update ZendeskTriggerButton to support custom component override - Add comprehensive tests for custom component usage - Update documentation with examples and usage guide This allows consumers to override the trigger button with their own components, avoiding issues with Tailwind utility classes and enabling better integration with custom design systems. Co-authored-by: gabrielremote <gabrielremote@users.noreply.github.com>
Contributor
📦 Bundle Size Report
Size Limits
Largest Files (Top 5)
View All Files (417 total)
✅ Bundle size check passed |
Contributor
|
Deploy preview for adp-cost-calculator ready!
Deployed with vercel-action |
Contributor
|
Deploy preview for remote-flows ready!
Deployed with vercel-action |
Add two new rules to prevent common issues when adding customizable components: 1. component-documentation.mdc - Ensures docs/COMPONENT_CUSTOMIZATION.md stays in sync when new components are added 2. component-pattern.mdc - Enforces the Main + Default component pattern with lazy loading These rules address issues found in PR #1262 where documentation updates and architectural patterns were missed. Related: PBYR-4544
Follow the established component pattern by separating business logic from presentation: - Create ZendeskTriggerButtonDefault.tsx with presentation logic - Refactor ZendeskTriggerButton.tsx to use component from context - Add to lazy-default-components.ts for lazy loading - Add to default-components.ts for tests This follows the pattern used by all other customizable components (ForcedValueField, ZendeskDrawer, etc.) where: - Main component contains business logic and requires component from context - Default component is pure presentation - Default is lazy-loaded to reduce bundle size - Tests use non-lazy default components Benefits: - Reduces bundle size for users who customize the component - Maintains consistency with codebase patterns - Separates concerns (logic vs presentation) - Enables proper lazy loading Related: PBYR-4544
Contributor
📊 Coverage Report
|
| Metric | Current | Previous | Change | Status |
|---|---|---|---|---|
| Lines | 85.42% | 85.44% | -0.02% | 🔴 |
| Statements | 84.98% | 85.00% | -0.02% | 🔴 |
| Functions | 83.56% | 83.66% | -0.10% | 🔴 |
| Branches | 76.89% | 76.89% | 0% | ⚪ |
Detailed Breakdown
Lines Coverage
- Covered: 4300 / 5034
- Coverage: 85.42%
- Change: -0.02% (9 lines)
Statements Coverage
- Covered: 4373 / 5146
- Coverage: 84.98%
- Change: -0.02% (9 statements)
Functions Coverage
- Covered: 1144 / 1369
- Coverage: 83.56%
- Change: -0.10% (2 functions)
Branches Coverage
- Covered: 2682 / 3488
- Coverage: 76.89%
- Change: 0% (3 branches)
✅ Coverage check passed
This was referenced Aug 21, 2026
gabrielseco
added a commit
that referenced
this pull request
Aug 21, 2026
Add two new rules to prevent common issues when adding customizable components: 1. component-documentation.mdc - Ensures docs/COMPONENT_CUSTOMIZATION.md stays in sync when new components are added 2. component-pattern.mdc - Enforces the Main + Default component pattern with lazy loading These rules address issues found in PR #1262 where documentation updates and architectural patterns were missed. Related: PBYR-4544
gabrielremote
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for customizing the
ZendeskTriggerButtoncomponent, addressing the issue raised in Linear issue PBYR-4544 where users need to override the trigger buttonThe request makes sense to make the library entirely headless which is the vision, which addresses technical debt
Linear Issue: PBYR-4544