Skip to content

RQD-14: Buildkite Migration + test fixes + -dev buildId suffix - #127

Merged
Domiii merged 34 commits into
masterfrom
dominik/crash-0044-tls-encout-nbufs-asserts
Jul 30, 2026
Merged

RQD-14: Buildkite Migration + test fixes + -dev buildId suffix#127
Domiii merged 34 commits into
masterfrom
dominik/crash-0044-tls-encout-nbufs-asserts

Conversation

@Domiii

@Domiii Domiii commented Jul 29, 2026

Copy link
Copy Markdown

Summary

This PR

  • replay_build_scripts/build-pipeline.py + .buildkite/runtime-node-build-and-test.yml (PipelineYamlHome in public node).
  • DevSuffix in build.js computeBuildId() (Chromium twin).
  • NodeRepo host mount for incremental make across jobs on the same agent.
  • REPLAY_BACKEND_REV paired to backend PR branch while in flight; must be re-pinned to backend master HEAD after backend lands.
  • Also carries prior TLSWrap EncOut / StreamBase Write assert diagnostics from the recycled branch.

Land order

  1. Land https://github.com/replayio/backend/pull/13123 first.
  2. Set REPLAY_BACKEND_REV = new backend master HEAD and push.
  3. Then merge this PR.

Out of scope

  • Replacing GHA as required check; macOS; EngFlow RBE (BSI-2).
  • test-jest harness follow-ups → RQD-16.

Narrow nbufs mismatch provenance before uv__try_write (crash-0044).

Co-authored-by: Cursor <cursoragent@cursor.com>
@Domiii Domiii self-assigned this Jul 29, 2026
@Domiii
Domiii requested a review from Andarist July 29, 2026 15:55
Domiii and others added 27 commits July 30, 2026 04:07
Chromium-twin BK graph in public node; pin BackendBranch for driver/build/test handoff.
…fault).

Co-authored-by: Cursor <cursoragent@cursor.com>
Mount the agent checkout+out over the image node path so cold full rebuilds are not forced every run.

Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Container git lacks GIT_CONFIG_*; safe.directory is set in run_node_build.sh.

Co-authored-by: Cursor <cursoragent@cursor.com>
prod/deploy-access-keys cannot s3:PutObject builds/; match build-node.yml and use the beefmaster agent identity inside docker.

Co-authored-by: Cursor <cursoragent@cursor.com>
Skip configure when out/Makefile exists for incremental NodeRepo make. Test steps need Hasura secret (ProcessorExit cascade without it).

Co-authored-by: Cursor <cursoragent@cursor.com>
Drop shallow fetch on the cached repo (it rewrote gyp mtimes and forced Makefile regen). Unshallow once if needed. df/du at job start for disk headroom.

Co-authored-by: Cursor <cursoragent@cursor.com>
Prior commit had unrelated staged deletions; keep additive pipeline work only.

Co-authored-by: Cursor <cursoragent@cursor.com>
reclaim_node_repo chown -R dirties every path via ctime; checkout -f then
rewrote all 32k sources and triggered Regenerating Makefile. Ignore ctime
and refresh the index after reclaim.

Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Domiii added 2 commits July 31, 2026 03:08
BK agent cache returns ETARGET for @types/node@24.3.1 which exists on the registry.
@Domiii Domiii changed the title Assert TLSWrap EncOut and StreamBase Write buffer counts RQD-14: runtime-node-build-and-test pipeline + DevSuffix pin Jul 30, 2026
@Domiii Domiii changed the title RQD-14: runtime-node-build-and-test pipeline + DevSuffix pin RQD-14: runtime-node-build-and-test pipeline + -dev buildId fix Jul 30, 2026
Floating main is vitest-era and never produces node_modules/.bin/jest.

Co-authored-by: Cursor <cursoragent@cursor.com>
@Domiii Domiii changed the title RQD-14: runtime-node-build-and-test pipeline + -dev buildId fix RQD-14: Buildkite Migration + test fixes + -dev buildId suffix Jul 30, 2026
Domiii added 2 commits July 31, 2026 04:25
Replaced by Buildkite runtime-node-build-and-test; keep workflow_dispatch only.
@Domiii
Domiii merged commit 469573c into master Jul 30, 2026
1 of 2 checks passed
@Domiii
Domiii deleted the dominik/crash-0044-tls-encout-nbufs-asserts branch July 30, 2026 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants