Skip to content

fix(velero): avoid broken pipe in cron-velero-update generate.sh #6113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xavpaice wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(velero): avoid broken pipe in cron-velero-update generate.sh #6113

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions addons/velero/template/generate.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,15 @@ function get_latest_release_version() {
function get_latest_tag_version() {
VAR_NAME=$1
local url=$2
local response
local version

version=$(curl -fsSL "$url" | \
grep -m1 '"name": "v' | \
# Fetch the full response before grepping. Under set -o pipefail, piping
# curl directly to grep -m1 can fail with exit code 23 when grep exits
# after the first match and closes the pipe. Using a here-string avoids
# the broken-pipe issue entirely.
response=$(curl -fsSL "$url")
version=$(grep -m1 '"name": "v' <<< "$response" | \
grep -Eo "[0-9]+\.[0-9]+\.[0-9]+")

export "$VAR_NAME=$version"
Expand Down
Loading