Skip to content

security(workflows): pin Helm install and verify checksum in prometheus and goldpinger update workflows - #6117

Open
xavpaice wants to merge 2 commits into
mainfrom
fix-helm-install-security-prom-goldpinger
Open

security(workflows): pin Helm install and verify checksum in prometheus and goldpinger update workflows#6117
xavpaice wants to merge 2 commits into
mainfrom
fix-helm-install-security-prom-goldpinger

Conversation

@xavpaice

Copy link
Copy Markdown
Member

Addresses the security review comment on the Rook update workflow PR (#6116) by applying the same fix to the Prometheus and Goldpinger update workflows.

Problem

Both workflows were installing Helm by piping the upstream get-helm-3 script directly to bash:

curl https://raw.githubusercontent.com/helm/helm/master/scripts/get-helm-3 | bash

This executes a mutable, unverified third-party script in a job that later uses the repository automation PAT (secrets.AUTOMATED_PR_GH_PAT).

Fix

Replace the pipe-to-bash install with a pinned Helm binary download and a hardcoded SHA-256 checksum verification:

- name: Install Helm
  env:
    HELM_VERSION: 4.2.4
    HELM_SHA256: c306b46f719b0a4da32d0f78ee21bf90ce8d602f15b22ab753f0674d1670a7f3
  run: |
    curl -fsSL "https://get.helm.sh/helm-v${HELM_VERSION}-linux-amd64.tar.gz" -o helm.tar.gz
    echo "${HELM_SHA256}  helm.tar.gz" | sha256sum -c
    tar -xzf helm.tar.gz
    sudo mv linux-amd64/helm /usr/local/bin/helm
    rm -rf helm.tar.gz linux-amd64

This pins the installer source and verifies the archive integrity before executing any Helm binary.

…us and goldpinger update workflows

Replaces the mutable curl | bash get-helm-3 installer with a pinned Helm
binary download and a hardcoded SHA-256 checksum verification, addressing the
same concern raised on the Rook update workflow PR.
@xavpaice
xavpaice requested a review from a team as a code owner August 28, 2026 05:14
@greptile-apps

greptile-apps Bot commented Aug 28, 2026

Copy link
Copy Markdown

Reviews (1): Last reviewed commit: "security(workflows): pin Helm install an..." | Re-trigger Greptile

Comment thread .github/workflows/update-goldpinger.yaml Outdated
Stay on the Helm 3 major version to avoid introducing potential breaking
changes from Helm 4 into the add-on generation scripts. Use the latest Helm 3
patch (3.21.4) with a hardcoded SHA-256 checksum.
@greptile-apps

greptile-apps Bot commented Aug 28, 2026

Copy link
Copy Markdown

Reviews (2): Last reviewed commit: "fixup! security(workflows): pin Helm 3.2..." | Re-trigger Greptile

@kriscoleman kriscoleman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants