security(workflows): pin Helm install and verify checksum in prometheus and goldpinger update workflows - #6117
Open
xavpaice wants to merge 2 commits into
Open
security(workflows): pin Helm install and verify checksum in prometheus and goldpinger update workflows#6117xavpaice wants to merge 2 commits into
xavpaice wants to merge 2 commits into
Conversation
…us and goldpinger update workflows Replaces the mutable curl | bash get-helm-3 installer with a pinned Helm binary download and a hardcoded SHA-256 checksum verification, addressing the same concern raised on the Rook update workflow PR.
|
Reviews (1): Last reviewed commit: "security(workflows): pin Helm install an..." | Re-trigger Greptile |
Stay on the Helm 3 major version to avoid introducing potential breaking changes from Helm 4 into the add-on generation scripts. Use the latest Helm 3 patch (3.21.4) with a hardcoded SHA-256 checksum.
|
Reviews (2): Last reviewed commit: "fixup! security(workflows): pin Helm 3.2..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the security review comment on the Rook update workflow PR (#6116) by applying the same fix to the Prometheus and Goldpinger update workflows.
Problem
Both workflows were installing Helm by piping the upstream
get-helm-3script directly to bash:curl https://raw.githubusercontent.com/helm/helm/master/scripts/get-helm-3 | bashThis executes a mutable, unverified third-party script in a job that later uses the repository automation PAT (
secrets.AUTOMATED_PR_GH_PAT).Fix
Replace the pipe-to-bash install with a pinned Helm binary download and a hardcoded SHA-256 checksum verification:
This pins the installer source and verifies the archive integrity before executing any Helm binary.