fix(header): don't close the "More" nav menu when clicking a hover-opened trigger - #1089
Merged
Merged
Conversation
…gger Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Contributor
Author
Manual verification — "More" menu hover→click papercutTested locally ( Primary flow: hover → click keeps the menu open
All assertions (all passed)
Minor behavioral note (matches Radix defaults, not a regression): after closing with the second click, the menu does not re-open until the pointer leaves and re-enters the trigger. |
JuampiRombola
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Radix's
NavigationMenuopens on hover but treats a trigger click as a toggle, so hovering "More" in the header (which opens it) and then clicking it immediately closed the menu — reported as a papercut on app.reserve.org.Fix is local to the header: a small
useHoverOpenTrigger()hook whose props are spread onto theMoreNavigationMenuTrigger. It tracks whether the current open came from a mouse hover and, if so,preventDefault()s the first click — Radix composes trigger handlers withcheckForDefaultPrevented, so itsonItemSelecttoggle is skipped and the menu stays open. A second click still closes it, and touch/keyboard toggling is untouched (pointerType === 'mouse'gate).No change to the shared
ui/navigation-menudefaults.Verification
src/components/layout/header/tests/hover-open-trigger.test.tsxdrives the real Radix menu: hover → click stays open, hover → click → click closes, and an unguarded control case reproduces the reported close (fails without the guard).pnpm lint,pnpm typecheck,pnpm test:rungreen (889 tests).Link to Devin session: https://app.devin.ai/sessions/42e20ceff5ee44ee94af8556edb2158c