Keep trailing module rebuild suffix when matching clones - #98
Open
atomicturtle wants to merge 1 commit into
Open
Keep trailing module rebuild suffix when matching clones#98atomicturtle wants to merge 1 commit into
atomicturtle wants to merge 1 commit into
Conversation
Greedy .module.+$ treated httpd 51.module+hash.1 and .5 as the same NVR as the first 8.7 build, so RLSA-2023:0852 and 1673 cloned the wrong packages. Prefix matching also accepted 51.1 as a rebuild of 51.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
clean_nvraused\.module.+$, sohttpd-2.4.37-51.module+el8.7.0+1059+126e9251,…+1155+5163394a.1, and…+1182+86a6cd60.5all cleaned to the same NVR.RLSA-2022:7647,2023:0852,2023:1673) with the first module build.51.1as a rebuild of51..rockyrebuilds still match.Test plan
python3 -m unittest apollo.tests.test_rh_matcher_activitiesclean_nvrakeys:module.httpd-2.4.37-51.x86_64vs…-51.1.x86_64vs…-51.5.x86_64RLSA-2023:0852/1673list their own httpd NEVRAs, not+1059+126e9251