fix(release): publish Windows archives as zip - #162
Open
pyroMain404 wants to merge 1 commit into
Open
pyroMain404 wants to merge 1 commit into
pyroMain404 wants to merge 1 commit into
Conversation
GoReleaser's default archive format is tar.gz on every platform, so the Windows release assets ship as .tar.gz. winget cannot consume those: its InstallerType enum has a zip member and no tar/gzip one, so no valid winget manifest can point at the current Windows assets. The Scoop manifest in scoop/ has the same problem, and .zip is in any case the native archive format on Windows. Override the format for goos: windows only; every other platform keeps tar.gz. Archive contents are unchanged. Refs reyamira#161
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #161.
What
One
format_overridesblock in.goreleaser.yml, sogoos: windowsproduces.zipinstead of.tar.gz. Every other platform is untouched.Why
winget cannot install Pass-CLI today, and no manifest can fix it: the
InstallerTypeenum in the manifest schema has azipmember and no tar/gzipone, so there is nothing valid to point at the current Windows release assets.
scoop/pass-cli.jsonis stuck on the same rock. And.zipis the native archiveformat on Windows — right now a user who downloads the asset by hand needs a
third-party tool to open it.
Full reasoning in #161.
Verification
goreleaser checkwith the pinned v2.16.0 (the version in.github/workflows/release.yml) reports the config valid. The only complaint isthe pre-existing
brewsdeprecation, which is identical onmain— I diffedthe output against an unpatched tree.
formats(plural) is the current key; GoReleaser v2.16.0 is well past thev2.6 rename from the singular
format.--snapshotrelease here (no Go toolchain on thismachine), so the produced archive names are not empirically confirmed. Worth a
glance at the next release's asset list — the expected names are
pass-cli_<version>_windows_x86_64.zipandpass-cli_<version>_windows_arm64.zip.Follow-up, not in this PR
Once a release carries the
.zipassets I have winget manifests ready to submitto microsoft/winget-pkgs — multi-file format,
ManifestVersion1.10.0,zip+NestedInstallerType: portable, x64 and arm64, validated against theofficial JSON schemas. Happy to open that PR as
reyamira.pass-cli, or to handthe manifests over if you would rather submit them yourselves.
Note that
scoop/pass-cli.jsonwill still be wrong after this change: it pointsat
pass-cli_$version_windows_amd64.zip, butname_templatemapsamd64tox86_64. It also still carries"version": "0.8.51"withv0.0.1URLs andplaceholder hashes, and states
MITwhere the repo is Apache-2.0. Left alonehere to keep this PR to one thing; say the word and I will send a separate one.