Skip to content

fix: make InteractiveChart tooltip dark-mode aware (#1043) #1106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RUKAYAT-CODER merged 2 commits into from
Jul 30, 2026
Merged

fix: make InteractiveChart tooltip dark-mode aware (#1043) #1106

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c847ed9
fix: make InteractiveChart tooltip dark-mode aware (#1043)
pharwasz Jul 30, 2026
5a011aa
fix: make InteractiveChart tooltip dark-mode aware (#1043)
pharwasz Jul 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 28 additions & 18 deletions src/components/charts/InteractiveChart.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import {
Bar,
Legend,
} from 'recharts';
import { useTheme } from '@/hooks/useTheme';

export type ChartType = 'line' | 'area' | 'bar';

Expand All @@ -37,6 +38,8 @@ export const InteractiveChart: React.FC<InteractiveChartProps> = ({
syncId,
className = '',
}) => {
const { resolvedTheme } = useTheme();

// Optimization for large datasets (10k+ points):
// If data is very large, we can sample it or simplify it before rendering
// But Recharts handles a few thousand points well. Let's add a simple sampling if data > 1000
Expand All @@ -46,6 +49,25 @@ export const InteractiveChart: React.FC<InteractiveChartProps> = ({
return data.filter((_, index) => index % factor === 0);
}, [data]);

// Theme-aware tooltip styles
const tooltipStyle = useMemo(() => {
const isDark = resolvedTheme === 'dark';
return {
backgroundColor: isDark ? 'rgba(31, 41, 55, 0.9)' : 'rgba(255, 255, 255, 0.9)',
borderRadius: '8px',
border: isDark ? '1px solid rgba(75, 85, 99, 0.5)' : 'none',
boxShadow: '0 4px 6px -1px rgb(0 0 0 / 0.1)',
color: isDark ? '#f3f4f6' : '#1f2937',
};
}, [resolvedTheme]);

const tooltipItemStyle = useMemo(() => {
const isDark = resolvedTheme === 'dark';
return {
color: isDark ? '#f3f4f6' : '#1f2937',
};
}, [resolvedTheme]);

const renderChart = () => {
switch (type) {
case 'area':
Expand All @@ -55,12 +77,8 @@ export const InteractiveChart: React.FC<InteractiveChartProps> = ({
<XAxis dataKey={xKey} tick={{ fontSize: 12 }} />
<YAxis tick={{ fontSize: 12 }} />
<Tooltip
contentStyle={{
backgroundColor: 'rgba(255, 255, 255, 0.9)',
borderRadius: '8px',
border: 'none',
boxShadow: '0 4px 6px -1px rgb(0 0 0 / 0.1)',
}}
contentStyle={tooltipStyle}
itemStyle={tooltipItemStyle}
/>
<Legend />
{yKeys.map((yConfig) => (
Expand All @@ -84,12 +102,8 @@ export const InteractiveChart: React.FC<InteractiveChartProps> = ({
<XAxis dataKey={xKey} tick={{ fontSize: 12 }} />
<YAxis tick={{ fontSize: 12 }} />
<Tooltip
contentStyle={{
backgroundColor: 'rgba(255, 255, 255, 0.9)',
borderRadius: '8px',
border: 'none',
boxShadow: '0 4px 6px -1px rgb(0 0 0 / 0.1)',
}}
contentStyle={tooltipStyle}
itemStyle={tooltipItemStyle}
/>
<Legend />
{yKeys.map((yConfig) => (
Expand All @@ -111,12 +125,8 @@ export const InteractiveChart: React.FC<InteractiveChartProps> = ({
<XAxis dataKey={xKey} tick={{ fontSize: 12 }} />
<YAxis tick={{ fontSize: 12 }} />
<Tooltip
contentStyle={{
backgroundColor: 'rgba(255, 255, 255, 0.9)',
borderRadius: '8px',
border: 'none',
boxShadow: '0 4px 6px -1px rgb(0 0 0 / 0.1)',
}}
contentStyle={tooltipStyle}
itemStyle={tooltipItemStyle}
/>
<Legend />
{yKeys.map((yConfig) => (
Expand Down
Loading