feat: Generate per-course metadata in courses/[courseId] instead of s… - #1120
Merged
Conversation
|
@OkeQueen Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Thank you for contributing to the project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generate per-course metadata in courses/[courseId]
Summary
Fixes #926
generateMetadata in courses/[courseId]/page.tsx was missing a per-course Open Graph image and canonical URL (title/description were already dynamic from an earlier commit).
Adds alternates.canonical and openGraph.url pointing to /courses/${courseId}, resolved against the existing metadataBase in src/app/layout.tsx.
Adds openGraph.images and twitter.images sourced from course.thumbnailUrl, omitted when a course has no thumbnail.
Changes
src/app/courses/[courseId]/page.tsx
return {
title:
${course.title} | TeachLink,description: course.description,
openGraph: {
title:
${course.title} | TeachLink,description: course.description,
type: 'website',
siteName: 'TeachLink',
twitter: {
card: 'summary_large_image',
site: '@TeachLink',
title:
${course.title} | TeachLink,description: course.description,
};
Test plan
npm install then npx tsc --noEmit (not run here — node_modules not installed in this environment)
npm run dev, visit /courses/ for a course with and without thumbnailUrl, inspect for og:image, og:url, and
Confirm Course Not Found case still returns the generic fallback metadata