Skip to content

fix(search): replace raw sort labels with i18n text - #1121

Merged
RUKAYAT-CODER merged 1 commit into
rinafcode:mainfrom
Talentgift24-ux:fix-search-results-sorter-labels
Jul 30, 2026
Merged

fix(search): replace raw sort labels with i18n text#1121
RUKAYAT-CODER merged 1 commit into
rinafcode:mainfrom
Talentgift24-ux:fix-search-results-sorter-labels

Conversation

@Talentgift24-ux

Copy link
Copy Markdown

#942 Replace developer-style sort labels in SearchResultsSorter with readable i18n text
Closes #942

Description

This PR addresses the UI inconsistency in the SearchResultsSorter component where raw developer-style sort identifiers (e.g., POPULARITY, NEWEST_FIRST) and the Sort_Sequence: label were hardcoded.

Changes made:

  • Replaced the hardcoded static labels with dynamic i18n translation keys using the useInternationalization hook.
  • Added corresponding translation keys (search.sortSequence and search.sort.*) to en.json, es.json, and ar.json.
  • Ensured the human-readable text matches the friendly labels already used across the application (e.g., in SearchResults.tsx).

Related Issue

Closes #942

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update

Checklist

  • Code follows project style guidelines
  • Self-review completed
  • No console errors
  • Uses Lucide icons consistently
  • Responsive design implemented
  • Starknet best practices followed

@drips-wave

drips-wave Bot commented Jul 30, 2026

Copy link
Copy Markdown

@Talentgift24-ux Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@RUKAYAT-CODER

Copy link
Copy Markdown
Contributor

Thank you for contributing to the project.

@RUKAYAT-CODER
RUKAYAT-CODER merged commit ce89a2a into rinafcode:main Jul 30, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace developer-style sort labels in SearchResultsSorter with readable i18n text

3 participants