Keep placeable load speed in sync with capacity overrides - #25
Open
user01010111 wants to merge 1 commit into
Open
Keep placeable load speed in sync with capacity overrides#25user01010111 wants to merge 1 commit into
user01010111 wants to merge 1 commit into
Conversation
user01010111
marked this pull request as ready for review
July 29, 2026 05:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Placeable load speed was recalculated from only the capacity fields passed to the current update. On storage with more than one override, changing or resetting one fill type could ignore a larger override that was still active.
Returning a capacity to its original value also produced a multiplier of
1.0, which the speed update treated as a no-op. This could leave the previous faster speed in place. Runtime changes to husbandry-food capacity did not refresh load speed either.This adds one load-speed refresh path that uses the complete stored override state. It restores the original speed when no expanded capacity remains and runs after resets and husbandry-food changes as well as normal storage updates. The existing policy of not scaling below the original speed is unchanged.
Tested with Lua syntax checks, XML validation, and local checks covering multiple fill-type overrides, specific resets, reset-all, shared storage, husbandry food, disabled scaling, and load-time fallback data.
This has not been tested in a live game session.