Skip to content

fix: service queued process-control RPCs beneath WASM parents - #2007

Open
WellDunDun wants to merge 2 commits into
rivet-dev:mainfrom
WellDunDun:codex/fix-nested-wasm-spawn
Open

WellDunDun wants to merge 2 commits into
rivet-dev:mainfrom
WellDunDun:codex/fix-nested-wasm-spawn

Conversation

@WellDunDun

@WellDunDun WellDunDun commented Sep 22, 2026

Copy link
Copy Markdown
  • Fix nested commands stalling when a WASM parent launches a shell that launches another process. Service queued process-control requests while preserving the parent's ownership of polling, output, and exit events.
  • Share control-RPC classification across requeueing, dispatch, and the event pump to prevent their method lists drifting apart.
  • Validation: the Rust workspace check, fixed-version check, and all three focused WASM-parent regressions pass. The added regression fails before the fix. On the 0.2.20 source pin, live shell probes and a real Codex subscription session successfully read a synthetic project brief with the unchanged adapter.
  • No authentication, filesystem permission, or persistence changes. A separate WASM-to-Node stdout-loss case remains outside this fix.

@the-company-company the-company-company Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟠 1 medium-severity finding

Reviewed commit 280bd16.

Comment thread crates/native-sidecar/src/execution/child_process.rs Outdated

@the-company-company the-company-company Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found

Reviewed commit 52ecf88.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant