Skip to content

docs(actors): sync from rivet-dev/actors - #76

Open
NathanFlurry wants to merge 1 commit into
mainfrom
docs-sync/actors
Open

NathanFlurry wants to merge 1 commit into
mainfrom
docs-sync/actors

Conversation

@NathanFlurry

Copy link
Copy Markdown
Member

Automated docs sync from rivet-dev/actors@c902026.

Do not edit vendor/actors/ here. Edit the docs in rivet-dev/actors and this PR updates itself.

@railway-app

railway-app Bot commented Sep 18, 2026

Copy link
Copy Markdown

🚅 Deployed to the website-pr-76 environment in rivet-website

Service Status Web Updated
website 😴 Sleeping (View Logs) Web Sep 18, 2026 at 10:55 pm UTC

@the-company-company the-company-company Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟠 2 medium-severity findings

Reviewed commit 9a63fb8.

Comment on lines +1791 to +1792
"null"
],

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟠 Medium · The schema assigns the wake-clear limit to the wrong setting

This description is rendered verbatim in the public configuration reference. It now tells readers that worker_max_workflows_per_pull controls both wake-condition clears (default 40,000) and leased workflows (default 1,000), while worker_max_wake_condition_clears_per_pull immediately above has lost its description entirely. The upstream runtime confirms these are separate fields with separate defaults. Move the 40,000 wake-clear comment back onto worker_max_wake_condition_clears_per_pull in the actors source, regenerate the schema, and resync this bundle.

Comment on lines +1774 to +1777
"null"
],
"format": "uint",
"minimum": 0.0

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟠 Medium · The schema accepts values that prevent startup

The generated schema allows 0, but the corresponding upstream Runtime::validate rejects zero for this new field, worker_poll_interval_ms, and every value in worker_max_wake_keys_per_workflow_name_per_pull (as well as the two adjacent pull limits). A configuration can therefore pass the downloadable schema and then be refused when the control plane starts. Generate minimum: 1 constraints for every field/value that must be greater than zero, then resync the artifact.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant