Skip to content

fix(rlix-drivers): forward resize-timeout env knobs to MilesCoordinator #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JunzheJoe wants to merge 1 commit into
base: zhenyu/m11-mvp-test
Choose a base branch
from
Open

fix(rlix-drivers): forward resize-timeout env knobs to MilesCoordinator #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions examples/rlix/run_miles_dual.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,6 +295,11 @@ def _build_pipeline(
"TMS_INIT_ENABLE_CPU_BACKUP",
"CUDA_DEVICE_MAX_CONNECTIONS",
"NCCL_NVLS_ENABLE",
# Resize-chain timeout knobs read inside the MilesCoordinator
# actor process (rlops/rlix#35); without explicit forwarding a
# driver-side export never reaches the actor on multi-node.
"RLIX_RESIZE_LOCK_TIMEOUT_S",
"MILES_RESIZE_RPC_TIMEOUT_S",
):
if (_v := os.environ.get(_k)) is not None:
pipeline_runtime_env_vars[_k] = _v
Expand Down
5 changes: 5 additions & 0 deletions examples/rlix/run_miles_rlix.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,11 @@ class MilesPipelineConfig:
"TMS_INIT_ENABLE_CPU_BACKUP",
"CUDA_DEVICE_MAX_CONNECTIONS",
"NCCL_NVLS_ENABLE",
# Resize-chain timeout knobs read inside the MilesCoordinator
# actor process (rlops/rlix#35); without explicit forwarding a
# driver-side export never reaches the actor on multi-node.
"RLIX_RESIZE_LOCK_TIMEOUT_S",
"MILES_RESIZE_RPC_TIMEOUT_S",
):
if (_v := os.environ.get(_k)) is not None:
pipeline_runtime_env_vars[_k] = _v
Expand Down