Fix creating new window does not work in Edge - #19
Open
ryanewtaylor wants to merge 1 commit into
Open
Conversation
Merged
dansam100
approved these changes
Mar 25, 2020
rmariuzzo
approved these changes
Oct 5, 2020
Owner
|
Hey there! I'm catching up with all pending PRs. I want to manually tests or setup tests for other browser, before merging this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This attempts to resolve issues with Edge and IE. With these changes popup works fine except...
... In Edge copying the styles seems to be very slow. It'll take several seconds to copy the parent styles in Edge while Chrome and Firefox are much faster (perceived, I have not timed it explicitly).
... In IE the styles are not copied over as Array.from is not available in IE. I believe the consumer will need to include a polyfill for this to work correctly.