Add 2nd demo - #5
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The changes are small, consistent across docs and script behavior, and directly address preventing build logs from leaking into the generated Pages index.
Pull request overview
This PR updates the demos catalog and the GitHub Pages assembly script to support publishing a second demo while ensuring build logs don’t corrupt the generated index.html.
Changes:
- Add the
temi-openapi-scenario-runnerdemo entry todemos/README.md. - Route demo build progress and
npmoutput to stderr indemos/assemble-pages.shto avoid contaminating the{ ... } > index.htmloutput. - Document the “stderr-only build logs” rule in
.cursor/rules/demos-pages.mdc.
File summaries
| File | Description |
|---|---|
| demos/README.md | Adds the second demo to the published demos catalog table. |
| demos/assemble-pages.sh | Redirects build progress and npm output to stderr so the generated Pages index remains clean. |
| .cursor/rules/demos-pages.mdc | Updates contributor guidance to match the script behavior regarding stderr-only build logs. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.