Skip to content

Add alertmanager condition for observe mode. - #1142

Open
thomaspanf wants to merge 2 commits into
masterfrom
alertmanager-observe-alert
Open

Add alertmanager condition for observe mode. #1142
thomaspanf wants to merge 2 commits into
masterfrom
alertmanager-observe-alert

Conversation

@thomaspanf

@thomaspanf thomaspanf commented Jul 27, 2026

Copy link
Copy Markdown
Member

This is a follow up to: #1120. The intention of this PR is to make it obvious when the node/watchtower is using a different address instead the real node address stored on disk.

  • Added an alertmanager condition for when observe mode is enabled
  • Print the observe mode warning on every node/watchtower loop iteration
  • Added a prompt to immediately restart the node/watchtower containers when using observe

@github-actions

Copy link
Copy Markdown

Coverage Report

@thomaspanf
thomaspanf marked this pull request as draft July 27, 2026 23:58
@github-actions

Copy link
Copy Markdown

Coverage Report

@github-actions

Copy link
Copy Markdown

Merging this branch will decrease overall coverage

Impacted Packages Coverage Δ 🤖
github.com/rocket-pool/smartnode/rocketpool-cli/service/config 0.00% (ø)
github.com/rocket-pool/smartnode/rocketpool-cli/wallet 0.00% (ø)
github.com/rocket-pool/smartnode/rocketpool/node 0.65% (-0.00%) 👎
github.com/rocket-pool/smartnode/rocketpool/watchtower 0.89% (-0.00%) 👎
github.com/rocket-pool/smartnode/shared/services/alerting 1.44% (-0.12%) 👎
github.com/rocket-pool/smartnode/shared/services/config 3.48% (-0.01%) 👎

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/rocket-pool/smartnode/rocketpool-cli/service/config/settings-alerting.go 0.00% (ø) 572 0 572
github.com/rocket-pool/smartnode/rocketpool-cli/wallet/end-masquerade.go 0.00% (ø) 328 (+24) 0 328 (+24)
github.com/rocket-pool/smartnode/rocketpool-cli/wallet/masquerade.go 0.00% (ø) 729 (+351) 0 729 (+351)
github.com/rocket-pool/smartnode/rocketpool/node/node.go 0.00% (ø) 3820 (+29) 0 3820 (+29)
github.com/rocket-pool/smartnode/rocketpool/watchtower/watchtower.go 0.00% (ø) 2778 (+29) 0 2778 (+29)
github.com/rocket-pool/smartnode/shared/services/alerting/alerting.go 1.44% (-0.12%) 1531 (+115) 22 1509 (+115) 👎
github.com/rocket-pool/smartnode/shared/services/config/alertmanager-config.go 3.01% (-0.55%) 365 11 (-2) 354 (+2) 👎

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

@thomaspanf
thomaspanf marked this pull request as ready for review July 28, 2026 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant