Skip to content

fix: segmentation fault on Vulkan (gfx1031 radv) #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Skyrion9 wants to merge 1 commit into from
Closed

fix: segmentation fault on Vulkan (gfx1031 radv) #38

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/s2_generate.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,8 @@ GenerateResult generate(
std::cout << "[Generate] Prefilling " << prompt.cols << " tokens..." << std::endl;
}
const auto prefill_t0 = std::chrono::steady_clock::now();
if (!model.prefill_fast(prompt_tm, prompt.cols, params.n_threads, state)) {
// using prefill_fast causes segfault on vulkan with specific architectures (RDNA2 radv gfx 1031)
if (!model.prefill(prompt_tm, prompt.cols, params.n_threads, state)) {
std::cerr << "[Generate] Prefill failed." << std::endl;
return out;
}
Expand Down