Fix libary statement complib postfixes - #323
Open
RokuSerhii wants to merge 23 commits into
Open
Conversation
# Conflicts: # src/debugSession/BrightScriptDebugSession.spec.ts # src/debugSession/BrightScriptDebugSession.ts # src/managers/ProjectManager.spec.ts # src/managers/ProjectManager.ts
Deleting interdependent component libraries makes the device emit transient compile errors (the main app/other complibs briefly reference a complib that was just removed). Add pause/resume/settle to CompileErrorProcessor and pause reporting during the delete sweep, resuming (after settle) only once we begin re-installing libraries to the device. Each zip upload waits for the resume to fully settle so real install errors are still surfaced. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…into library.statement
RokuSerhii
commented
Jul 9, 2026
TwitchBronBron
changed the title
library statements
TwitchBronBron
added
the
create-vsix
Resolved merge conflict in ProjectManager.spec.ts by keeping both JSZip and undent imports.
TwitchBronBron
removed
the
create-vsix
Contributor
|
Hey there! I just built a new version of the vscode extension based on a7a0b76. Download: |
Contributor
|
Hey there! I just built a new version of the vscode extension based on 5525fcc. Download: |
TwitchBronBron
changed the title
library statementslibary statement complib postfixes
chrisdp
added
the
create-vsix
chrisdp
removed
the
create-vsix
This was referenced Jul 20, 2026
Contributor
|
Hey there! I just built a new version of the vscode extension based on 2333c41. Download: |
`Library` statement postfixing previously only understood `bs_libs_provided` and `bs_libs_required`. Add support for `sg_component_libs_provided` and `sg_component_libs_required`, keeping the two mechanisms strictly separate: a `bs_libs_required` name is only ever satisfied by a `bs_libs_provided` library, and an `sg_component_libs_required` name only by an `sg_component_libs_provided` library. A single library may broadcast itself under both by declaring both manifest keys. - `Project` gains `bsLibsRequired` / `sgComponentLibsRequired` - `ComponentLibraryProject` gains `bsLibsProvided` / `sgComponentLibsProvided` (each manifest value is comma-delimited, so all are lists) - each `Library` statement resolves its provider per-mechanism inline; when two different libraries export the same file name (one per mechanism) we can't know which the device loads, so warn and prefer the bs lib - skip the file walk unless at least one required library is actually provided - add `util.splitAndTrim` for the comma-delimited manifest values Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
|
Hey there! I just built a new version of the vscode extension based on 9e658d8. Download: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ComponentLibraryProject.postfixFiles()does a postfix of files with__liband changes all references inside the library, but it doesn't apply this postfix forLibrary "file_name.brs"in the appSo if that library and app are sideloaded to the device, the compilation of the app fails because the
Librarystatement points to a file without a postfix