Migrate to roku-deploy v4 - #398
Draft
chrisdp wants to merge 1 commit into
Draft
Conversation
Move every roku-deploy call to the v4 named-options API and the unified device option: - publish -> sideload (explicit close: false and deleteDevChannel: false to preserve existing behavior) - pressHomeButton -> keyPress with the home key - deleteInstalledChannel -> deleteDevChannel - prepublishToStaging -> stage, zipFolder -> zip - getFilePaths named options (dest is staging-relative; ProjectManager absolutizes) - getOptions/getOutputZipFilePath replaced with RokuDeploy.defaults and the getStagingDir/getOutputZipPath resolvers - host/remotePort call sites now build a device option; the private BrightScriptDebugSession.device getter is the single place the launch configuration becomes a roku-deploy device config
| password: this.launchConfiguration.password, | ||
| username: this.launchConfiguration.username, | ||
| packagePort: this.launchConfiguration.packagePort | ||
| }); |
Collaborator
There was a problem hiding this comment.
We can set most of these in the RokuDeploy constructor and it will persist. That way we don't have to repeat the same parameters over and over.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves every roku-deploy call to the v4 named-options API and the unified
deviceoption (roku-deploy PR rokucommunity/roku-deploy#323, plus the defaults/resolvers from rokucommunity/roku-deploy#330).publish->sideload, passing explicitclose: falseanddeleteDevChannel: falsesince v4 enables both by default and roku-debug handles them itselfpressHomeButton->keyPresswith the home keydeleteInstalledChannel->deleteDevChannelprepublishToStaging->stage,zipFolder->zip,getFilePathsnamed options (dest paths are now staging-relative, so ProjectManager absolutizes them)getOptions/getOutputZipFilePathare gone in v4; replaced withRokuDeploy.defaultsand thegetStagingDir/getOutputZipPathresolvershost/remotePortcall site now builds adeviceoption; the privateBrightScriptDebugSession.devicegetter is the single place the launch configuration becomes a roku-deploy device config, so future addressing schemes (like the Roku Cloud Emulator) only need to be handled thereDraft: builds against a local roku-deploy checkout of the unified-device-option work; the package.json bump will follow separately once a v4 alpha containing it is published.