Skip to content

Add python3-colorama dependency - #892

Open
penww wants to merge 1 commit into
ros2:masterfrom
penww:master
Open

Add python3-colorama dependency#892
penww wants to merge 1 commit into
ros2:masterfrom
penww:master

Conversation

@penww

@penww penww commented Aug 27, 2026

Copy link
Copy Markdown

Description

Fix CI issue for ros2/ros2cli#1248. In that PR, we added color support for ros2cli, python3-colorama is used for cross-platform colored terminal output.

Did you use Generative AI?

No.

Additional Information

https://pypi.org/project/colorama/

Signed-off-by: Peng Wang <penwang@qti.qualcomm.com>

@knmcguire knmcguire left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! I don't think it is a good idea to add dependencies of actual ros packages here, and these should only be dependencies to support CI as a whole I believe.

Have you tried adding python3-colorama to rosdep?

(let me double check this internally as well, as I see in the console that rosdep is not even called indeed)

@clalancette

Copy link
Copy Markdown
Contributor

Have you tried adding python3-colorama to rosdep?

That's already done: https://github.com/ros/rosdistro/blob/2667056d0320bb77edf1e28fec13d56aa8d325e2/rosdep/python.yaml#L3476

But unfortunately, CI here does not use rosdep at all. I tried to introduce it a few years ago, but it would basically require completely rewriting how the CI scripts work. So I abandoned it then. I think this is the best we can do for now.

Note that this will also require adding in python3-colorama to https://github.com/ros2/ros2/blob/rolling/pixi.toml for Windows.

@knmcguire

knmcguire commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator

ahh yes thanks @clalancette for clarifying. I looked at the base.yaml file, that's why I missed it.

And indeed, pixi.toml addition needs to be done as well (colorama is on conda-forge). We should be able to use version 0.4.6 for this to match Ubuntu 26.04

@penww

penww commented Aug 28, 2026

Copy link
Copy Markdown
Author

@clalancette @knmcguire Thanks for your review and feedback, have added PR for Windows in pixi.toml: ros2/ros2#1857.

Please help to review again.

@knmcguire

Copy link
Copy Markdown
Collaborator

I had to make a port of your branch for here for me to test it out in CI.

Linux: Build Status
Linux-rhel: Build Status
Linux-Aarch64: Build Status

Windows CI run with pixi is running in the other PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants