Skip to content

Allow SetUseSimTime to disable simulated time - #553

Open
Old-Ding wants to merge 1 commit into
ros2:rollingfrom
Old-Ding:codex/allow-disabling-sim-time
Open

Allow SetUseSimTime to disable simulated time#553
Old-Ding wants to merge 1 commit into
ros2:rollingfrom
Old-Ding:codex/allow-disabling-sim-time

Conversation

@Old-Ding

Copy link
Copy Markdown

Summary

  • compare the resulting use_sim_time value with the requested boolean instead of requiring it to be true
  • preserve the existing failure path when the resulting value does not match the request
  • extend the XML and YAML frontend test with native false values while retaining true substitution coverage

Testing

  • reproduced the current RuntimeError after SetUseSimTime(False) had already set the parameter to false
  • passed XML/YAML true and false parser-to-action execution probes using the real launch frontends and a fake node at the unavailable rclpy boundary
  • ament_flake8 on both changed files
  • ament_pep257 on both changed files
  • ament_copyright on both changed files
  • python -m py_compile on both changed files
  • git diff --check

The repository-native frontend test was not run locally because this Windows environment does not have a compiled rclpy extension.

Validate the resulting use_sim_time value against the requested boolean instead of requiring it to be true.

Extend the XML and YAML frontend test to cover disabling simulated time while retaining the existing substitution coverage.

Signed-off-by: Old-Ding <35417409+Old-Ding@users.noreply.github.com>
@mergify

mergify Bot commented Jul 11, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant