Allow SetUseSimTime to disable simulated time - #553
Open
Old-Ding wants to merge 1 commit into
Open
Conversation
Validate the resulting use_sim_time value against the requested boolean instead of requiring it to be true. Extend the XML and YAML frontend test to cover disabling simulated time while retaining the existing substitution coverage. Signed-off-by: Old-Ding <35417409+Old-Ding@users.noreply.github.com>
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
use_sim_timevalue with the requested boolean instead of requiring it to betruefalsevalues while retaining true substitution coverageTesting
RuntimeErrorafterSetUseSimTime(False)had already set the parameter to falseament_flake8on both changed filesament_pep257on both changed filesament_copyrighton both changed filespython -m py_compileon both changed filesgit diff --checkThe repository-native frontend test was not run locally because this Windows environment does not have a compiled
rclpyextension.