an explicit platform split matching the helper header's own condition. - #587
Merged
Conversation
Signed-off-by: Tomoya Fujita <fujita.tomoya@triorb.co.jp>
|
Tick the box to add this pull request to the merge queue (same as
|
Collaborator
Author
|
Pulls: #587 |
fujitatomoya
commented
Aug 19, 2026
fujitatomoya
left a comment
Collaborator
Author
There was a problem hiding this comment.
i think this is a best option we got, any thoughs or better idea?
Collaborator
Author
mini-1235
reviewed
Aug 20, 2026
|
This works for me. Thanks! |
Collaborator
Author
mjcarroll
approved these changes
Aug 24, 2026
ahcorde
approved these changes
Aug 24, 2026
Contributor
|
@fujitatomoya should we backport this one ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
replaces #586
note: I first applied ATOMIC_VAR_INIT(-1) as suggested, but when I tested it in C23 mode (gcc -std=gnu2x), it failed — ATOMIC_VAR_INIT is already removed from this toolchain's <stdatomic.h>, producing "implicit declaration of function 'ATOMIC_VAR_INIT'" followed by "initializer element is not constant". which isn't theoretical. I switched to the fallback to have an explicit platform split matching the helper header's own condition.
Fixes # (issue)
Is this user-facing behavior change?
No
Did you use Generative AI?
No
Additional Information