Skip to content

Add multicast options to ros2 doctor hello - #1267

Merged
ahcorde merged 2 commits into
ros2:rollingfrom
Miko997:doctor-hello-multicast-options
Aug 26, 2026
Merged

Add multicast options to ros2 doctor hello#1267
ahcorde merged 2 commits into
ros2:rollingfrom
Miko997:doctor-hello-multicast-options

Conversation

@Miko997

@Miko997 Miko997 commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Description

Add optional --group and --port arguments to ros2 doctor hello. The selected values are used by the multicast sender and receiver and shown in the summary. Existing defaults remain unchanged.

This implements the multicast configuration part of #1077. The other enhancements in that issue are outside this PR.

Is this user-facing behavior change?

Yes. Users can select the multicast group and port used by ros2 doctor hello.

Additional Information

Post-review validation:

  • git diff --check origin/rolling...HEAD
  • python3 -m py_compile ros2doctor/ros2doctor/verb/hello.py ros2doctor/test/test_cli.py
  • focused argument validation accepted 225.0.0.2 and rejected 127.0.0.1, not-an-address, and ff02::1
  • ament_flake8 and ament_pep257 passed on the changed files

The full ROS 2 package test suite was not rerun after the review update.

Signed-off-by: Miko Parkkinen <141511110+Miko997@users.noreply.github.com>
@mergify

mergify Bot commented Aug 12, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

Comment thread ros2doctor/ros2doctor/verb/hello.py
Comment thread ros2doctor/test/test_cli.py
Generated-by: OpenAI Codex (GPT-5)
Signed-off-by: Miko Parkkinen <141511110+Miko997@users.noreply.github.com>
@Miko997
Miko997 requested a review from fujitatomoya August 23, 2026 19:18
@fujitatomoya

Copy link
Copy Markdown
Collaborator

Pulls: #1267
Gist: https://gist.githubusercontent.com/fujitatomoya/d1427c44471cf6bf77af1c65fdbe2361/raw/4dee95e32e013daa3755a7f14c74fe197b4dc390/ros2.repos
BUILD args: --packages-above-and-dependencies ros2doctor
TEST args: --packages-above ros2doctor
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/20224

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde
ahcorde merged commit 7b47206 into ros2:rolling Aug 26, 2026
2 checks passed
@ahcorde

ahcorde commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

@fujitatomoya should we backport this one ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants