Fix Pipenv discovery when here cannot find a project root - #1913
Merged
Conversation
t-kalinowski
force-pushed
the
fix/pipenv-project-root
branch
from
July 30, 2026 22:05
2ad0856 to
5943781
Compare
t-kalinowski
force-pushed
the
fix/pipenv-project-root
branch
from
July 30, 2026 23:23
5943781 to
e9e7cd0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1909.
Pipenv discovery could repeat project-root resolution after locating a Pipfile. If
here::here()failed on that second lookup, reticulate discarded the Pipenv result and continued discovery.Reticulate now passes the located Pipfile directory to
pipenv_python(). A no-argument call also returnsNULLwhenherecannot resolve a root.Changes
Public-facing:
herecannot independently resolve the project root.hereroot no longer surfaces from a no-argument Pipenv probe.Internal:
py_discover_config()with a temporary Pipenv environment.