Keep the DRb connection pool alive after socket errors - #57
Closed
OskarEichler wants to merge 1 commit into
Closed
Conversation
Member
|
Could you also share your real world problems instead of just opening auto generated PRs to many repositories? |
Author
|
This was generated from a broad dependency audit, not from a specific Songstats production incident. I can explain the hypothetical dead-worker path, but I cannot honestly provide a real-world failure that motivated it. That context is not strong enough for this change, so I am closing the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contains stale-connection liveness and eviction-close errors inside the pool worker, closing broken entries when possible so later callers do not deadlock behind a dead worker.
Verified with the full 122-test / 547-assertion suite and focused stale/eviction error models.