Return the unique ID from single-message UIDL replies - #33
Open
OskarEichler wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Return the unique ID, rather than the message number, from a single-message UIDL reply. A reply is
+OK message-number unique-id; the current parser returns the second token. Use whitespace splitting and take the third token, retaining the ID's case and bytes.Reproduction
This follows the single-message UIDL example in RFC 1939 section 7.
Verification
git diff --checkpass; supplemental lint was compared with baseline.Compatibility and limits
No API signature change. The internal
POP3Command#uidl(number)intentionally returns the correct ID instead of a message number; callers relying on the wrong value will observe a change. The multiline path used byPOPMail#unique_idis unchanged. No new strict malformed-response validation is introduced.This is separate from issue #27's reported multiline chunk loss. That issue did not reproduce in the bounded current-reader checks above; this PR does not claim to resolve it. Other Ruby/OS runtimes and external mail providers were not tested; no production or external mailbox access occurred.