Make SymbolNode#value_loc non-optional - #4220
Merged
Merged
Conversation
Sort of a followup for ruby@929aec1 It changed the value for `:''` into nil/null, which is a bit inconvenient. For syntax-valid code I expect it to always be present. It's also inconsistent with `StringNode`. In effect, this reverts the snapshots changes and the two changes in ruby for the ripper/parser compiler.
Earlopain
force-pushed
the
symbol-value-required
branch
from
September 4, 2026 09:08
7218c9e to
5c06479
Compare
Collaborator
Author
|
We can't have locations that can legitimatly be zero-length be optional anymore, now that optional locations use zero length to indicate absence. I quickly checked the other optional locations and didn't find anything else with this ambiguity |
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Sep 13, 2026
(ruby/prism#4220) Sort of a followup for ruby/prism@929aec1 It changed the value for `:''` into nil/null, which is a bit inconvenient. For syntax-valid code I expect it to always be present. It's also inconsistent with `StringNode`. In effect, this reverts the snapshots changes and the two changes in ruby for the ripper/parser compiler. ruby/prism@531cd5e557
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sort of a followup for 929aec1 / #3772
It changed the value for
:''into nil/null, which is a bit inconvenient. For syntax-valid code I expect it to always be present.It's also inconsistent with
StringNode. In effect, this reverts the snapshots changes and the two changes in ruby for the ripper/parser compiler.