Presidents Timeline in Committee Members Page - #490
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a “Presidents Timeline” visualization to the Committee Members page, sourcing presidential term data from existing committee YAML data and computing timeline segments in CommitteeHelper.
Changes:
- Extend committee data YAML to include president term start/end dates (including missing historical president entry data).
- Render a timeline chart on
committee-memberspage using helper-provided president/term calculations. - Add a helper spec to validate the presidents data pipeline.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
app/helpers/committee_helper.rb |
Adds logic to load, group, and compute timeline term segments for presidents. |
app/views/pages/committee-members.html.erb |
Renders the presidents timeline UI above the committee members grid. |
config/data/committee.yml |
Adds start/end dates for the current president’s term. |
config/data/previous.yml |
Adds/updates historical president term ranges and appends a missing president entry. |
spec/helpers/committee_helper_spec.rb |
Introduces initial tests for CommitteeHelper#presidents. |
|
@simonhildebrandt , I have made adjustments according to your advice and copilot suggestions. Please see comments for each item and review those updates. |
simonhildebrandt
left a comment
There was a problem hiding this comment.
The mocks look great, and so does the result. Well done!
(One small question on the committee members template, but I won't hold up the PR for that.)
32b9e8a to
38786a2
Compare
leesheppard
left a comment
There was a problem hiding this comment.
Thank you for your work @mu-tsu-mi appreciate your time and effort!
I added a timeline for Ruby Australia presidential history to the current committee members page based on the idea by @ZimbiX . Please refer below and review this request.
I used the existing yml files (committee.yml for the current president and previous.yml for all of previous presidents) to get president names, term start and term end. Presidents data is sourced from forum archive, Slack announcements and commits to those yml files. All logic for this timeline lives in the committee_helper file.