Skip to content

Presidents Timeline in Committee Members Page - #490

Merged
leesheppard merged 14 commits into
rubyaustralia:mainfrom
mu-tsu-mi:presidents_table
Aug 4, 2026
Merged

Presidents Timeline in Committee Members Page#490
leesheppard merged 14 commits into
rubyaustralia:mainfrom
mu-tsu-mi:presidents_table

Conversation

@mu-tsu-mi

Copy link
Copy Markdown
Contributor

I added a timeline for Ruby Australia presidential history to the current committee members page based on the idea by @ZimbiX . Please refer below and review this request.

I used the existing yml files (committee.yml for the current president and previous.yml for all of previous presidents) to get president names, term start and term end. Presidents data is sourced from forum archive, Slack announcements and commits to those yml files. All logic for this timeline lives in the committee_helper file.

Screenshot 2026-07-18 at 4 38 32 pm

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a “Presidents Timeline” visualization to the Committee Members page, sourcing presidential term data from existing committee YAML data and computing timeline segments in CommitteeHelper.

Changes:

  • Extend committee data YAML to include president term start/end dates (including missing historical president entry data).
  • Render a timeline chart on committee-members page using helper-provided president/term calculations.
  • Add a helper spec to validate the presidents data pipeline.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
app/helpers/committee_helper.rb Adds logic to load, group, and compute timeline term segments for presidents.
app/views/pages/committee-members.html.erb Renders the presidents timeline UI above the committee members grid.
config/data/committee.yml Adds start/end dates for the current president’s term.
config/data/previous.yml Adds/updates historical president term ranges and appends a missing president entry.
spec/helpers/committee_helper_spec.rb Introduces initial tests for CommitteeHelper#presidents.

Comment thread app/helpers/committee_helper.rb
Comment thread app/helpers/committee_helper.rb
Comment thread app/helpers/committee_helper.rb
Comment thread app/helpers/committee_helper.rb
Comment thread app/views/pages/committee-members.html.erb Outdated
Comment thread config/data/previous.yml
Comment thread spec/helpers/committee_helper_spec.rb
Comment thread app/helpers/committee_helper.rb Outdated
@mu-tsu-mi

Copy link
Copy Markdown
Contributor Author

@simonhildebrandt , I have made adjustments according to your advice and copilot suggestions. Please see comments for each item and review those updates.

Comment thread app/views/pages/previous-committee-members.html.erb Outdated

@simonhildebrandt simonhildebrandt left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mocks look great, and so does the result. Well done!

(One small question on the committee members template, but I won't hold up the PR for that.)

@leesheppard leesheppard left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work @mu-tsu-mi appreciate your time and effort!

@github-project-automation github-project-automation Bot moved this from Todo to Done in RubyAU Community PM Aug 4, 2026
@leesheppard
leesheppard merged commit e2f7c2b into rubyaustralia:main Aug 4, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants