Skip to content

fix: normalise sqlite timestamps to UTC in timeToString (RUK-139) #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ruko1202 merged 1 commit into from
May 25, 2026
Merged

fix: normalise sqlite timestamps to UTC in timeToString (RUK-139) #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion internal/storages/sqlite/bind.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,19 @@ func fromDBModels(ctx context.Context, dbTasks []*model.GoqueTask) ([]*entity.Ta
return tasks, nil
}

// timeToString serializes t to RFC3339 in UTC. Forcing UTC is what
// keeps lexicographic compare consistent with chronological order:
// SQLite stores TEXT, and a row written with a local-zone offset
// (e.g. "2026-05-25T16:00:00+03:00") would compare wrong against a
// UTC-zone row ("2026-05-25T13:00:00Z") even though both moments
// are equal. All WHERE clauses in this package format the comparison
// value via timeToString too, so as long as everything goes through
// here the order is stable. See RUK-139 for the underlying hazard
// and why we did NOT migrate the column to INTEGER unix-seconds:
// SQLite is positioned as dev/test only and the UTC normalisation
// closes the practical risk surface.
func timeToString(t time.Time) string {
return t.Format(timeFormat)
return t.UTC().Format(timeFormat)
}

func timeFromString(value string) time.Time {
Expand Down
Loading