chore: drop duplicate error log in PG/MySQL GetTasksForProcessing - #24
Merged
Conversation
The inner helper logged "failed to get task for processing", the outer storage.GetTasksForProcessing logged the same string, and baseProcessor.doProcessQueue logged "process queue failed" once more — three log lines per failure. Stripped the inner one to match what RUK-133 did for CureTasks. RUK-140 (adding FOR UPDATE SKIP LOCKED) closed as won't-fix-yet: plain FOR UPDATE preserves correctness, the throughput plateau only matters under heavy horizontal scale (many service instances on the same queue) which isn't measured here. Worth revisiting when there's a real production signal. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The inner helper logged "failed to get task for processing", the
outer storage.GetTasksForProcessing logged the same string, and
baseProcessor.doProcessQueue logged "process queue failed" once
more — three log lines per failure. Stripped the inner one to
match what RUK-133 did for CureTasks.
RUK-140 (adding FOR UPDATE SKIP LOCKED) closed as won't-fix-yet:
plain FOR UPDATE preserves correctness, the throughput plateau
only matters under heavy horizontal scale (many service instances
on the same queue) which isn't measured here. Worth revisiting
when there's a real production signal.
Co-Authored-By: Claude Opus 4.7 noreply@anthropic.com