Add defmt feature for riscv crate - #423
Merged
Merged
Conversation
Contributor
Author
|
One other thing I've run into in my error logging is the lack of defmt support for |
Contributor
|
I think you can include It in this same PR |
TechnoPorg
force-pushed
the
push-kmmvsqlxspru
branch
from
October 3, 2026 00:29
1632e10 to
abdfe71
Compare
Contributor
Author
|
Done! This is ready for review now 😄 |
romancardenas
requested changes
Oct 5, 2026
romancardenas
left a comment
romancardenas
left a comment
Contributor
There was a problem hiding this comment.
Thanks! I added 3 comments that all address to the same issue.
TechnoPorg
force-pushed
the
push-kmmvsqlxspru
branch
from
October 5, 2026 12:27
eb54cfa to
fce27c2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #335 which adds the same feature to
riscvand implements the trait on commonly used enums.