Skip to content

edition flag, unsafe(no_mangle) - #891

Merged
burrbull merged 2 commits into
masterfrom
unsafe-attr
Aug 14, 2025
Merged

burrbull merged 2 commits into
masterfrom
unsafe-attr

Conversation

@burrbull

@burrbull burrbull commented Dec 11, 2024 •

Copy link
Copy Markdown
Member

Fix compilation on nightly, but bumps Rust to 1.82

cc @Emilgardis

@burrbull
burrbull requested a review from a team as a code owner December 11, 2024 20:35
@burrbull

Copy link
Copy Markdown
Member Author

Alternative is to just force edition 2021 in CI

@Emilgardis

Copy link
Copy Markdown
Member

I think specifying 2021 is the way to go for now

@burrbull

Copy link
Copy Markdown
Member Author

I think specifying 2021 is the way to go for now

#892

@burrbull
burrbull marked this pull request as draft December 14, 2024 16:59
@burrbull burrbull changed the title unsafe no-mangle edition flag, unsafe(no_mangle) Aug 14, 2025
@burrbull
burrbull marked this pull request as ready for review August 14, 2025 15:45
@burrbull

Copy link
Copy Markdown
Member Author

/ci diff pr --current " --edition=2024"

@github-actions

Copy link
Copy Markdown

Diff for comment

@burrbull

Copy link
Copy Markdown
Member Author

cc @Emilgardis includes #933

@Emilgardis Emilgardis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@burrbull
burrbull added this pull request to the merge queue Aug 14, 2025
Merged via the queue into master with commit 0f42ae3 Aug 14, 2025
@burrbull
burrbull deleted the unsafe-attr branch August 14, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants