Skip to content

[beta-1.99] backport 17401 and 17366 - #17403

Merged
epage merged 12 commits into
rust-lang:rust-1.99.0from
weihanglo:beta-1.99-backport
Aug 28, 2026
Merged

epage merged 12 commits into
rust-lang:rust-1.99.0from
weihanglo:beta-1.99-backport

Conversation

@weihanglo

@weihanglo weihanglo commented Aug 27, 2026 •

Copy link
Copy Markdown
Member

@rustbot rustbot added A-cache-messages Area: caching of compiler messages A-cfg-expr Area: Platform cfg expressions A-configuration Area: cargo config files and env vars A-layout Area: target output directory layout, naming, and organization Command-fix labels Aug 27, 2026
Prepares workspace remap for emitting multiple rules.
This is effectively `library/=<to>/library`
and `compiler/=<to>/compiler` in rustc bootstrap,
when `__CARGO_RUSTC_BOOTSTRAP_WS_REMAP` is set.

This isn't needed for normal cases
because relative member paths are exactly what users want.

See <rust-lang/rust#161049 (comment)>
@weihanglo
weihanglo marked this pull request as ready for review August 28, 2026 00:07
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 28, 2026
@rustbot

rustbot commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator

r? @epage

rustbot has assigned @epage.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @epage, @weihanglo
  • @epage, @weihanglo expanded to epage, weihanglo

@rustbot

rustbot commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against rust-1.99.0. Please double check that you specified the right target!

@rustbot rustbot added A-environment-variables Area: environment variables A-home Area: the `home` crate A-testing-cargo-itself Area: cargo's tests labels Aug 28, 2026
weihanglo and others added 8 commits August 27, 2026 20:28
See <https://github.com/rust-lang/cargo/actions/runs/32992508559/job/98253339881>

```
warning: redundant explicit link target
  --> crates/home/src/lib.rs:81:42
   |
81 | /// For more details, see [`cargo_home`](fn.cargo_home.html).
   |                            ------------  ^^^^^^^^^^^^^^^^^^ explicit target is redundant
   |                            |
   |                            because label contains path that resolves to same destination
   |
   = note: when a link's destination is not specified,
           the label is used to resolve intra-doc links
   = note: `#[warn(rustdoc::redundant_explicit_links)]` on by default
help: remove explicit link target
   |
81 - /// For more details, see [`cargo_home`](fn.cargo_home.html).
81 + /// For more details, see [`cargo_home`].
   |

warning: redundant explicit link target
   --> crates/home/src/lib.rs:118:43
    |
118 | /// For more details, see [`rustup_home`](fn.rustup_home.html).
    |                            -------------  ^^^^^^^^^^^^^^^^^^^ explicit target is redundant
    |                            |
    |                            because label contains path that resolves to same destination
    |
    = note: when a link's destination is not specified,
            the label is used to resolve intra-doc links
help: remove explicit link target
    |
118 - /// For more details, see [`rustup_home`](fn.rustup_home.html).
118 + /// For more details, see [`rustup_home`].
    |

error: `home` (lib doc) generated 2 warnings
```
next trait resolver might have bugs dealing with it,
but anyway we care less about intra doclinks for resolver-tests,
and it anyway builds in clippy jobs.
@rustbot rustbot added the A-infrastructure Area: infrastructure around the cargo repo, ci, releases, etc. label Aug 28, 2026
@epage
epage merged commit 5f94df4 into rust-lang:rust-1.99.0 Aug 28, 2026
31 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 28, 2026
@weihanglo
weihanglo deleted the beta-1.99-backport branch August 28, 2026 01:12
rust-bors Bot pushed a commit to rust-lang/rust that referenced this pull request Aug 28, 2026
[beta-1.99] Update cargo submodule backport

1 commits in eb98b54bc9f3c74519f43d066cb3fd02ebc88df0..5f94df4789f005f9a352888e8355ffc645b7ed0e
2026-08-11 16:00:29 +0000 to 2026-08-27 20:07:23 -0500
- [beta-1.99] backport 17401 and 17366 (rust-lang/cargo#17403)
rust-bors Bot pushed a commit to rust-lang/rust that referenced this pull request Aug 28, 2026
[beta-1.99] Update cargo submodule backport

1 commits in eb98b54bc9f3c74519f43d066cb3fd02ebc88df0..5f94df4789f005f9a352888e8355ffc645b7ed0e
2026-08-11 16:00:29 +0000 to 2026-08-27 20:07:23 -0500
- [beta-1.99] backport 17401 and 17366 (rust-lang/cargo#17403)
@rustbot rustbot added this to the 1.99.0 milestone Aug 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cache-messages Area: caching of compiler messages A-cfg-expr Area: Platform cfg expressions A-configuration Area: cargo config files and env vars A-environment-variables Area: environment variables A-home Area: the `home` crate A-infrastructure Area: infrastructure around the cargo repo, ci, releases, etc. A-layout Area: target output directory layout, naming, and organization A-testing-cargo-itself Area: cargo's tests Command-fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants