Specify --edition in messages tests - #17470
Merged
Merged
Conversation
As part of notifying users calling bare `rustc` without an explicit edition that they should likely be using the 2024 edition, update cargo tests to not trigger the new user facing note.
rustbot
added
the
S-waiting-on-review
Collaborator
|
r? @weihanglo rustbot has assigned @weihanglo. Use Why was this reviewer chosen?The reviewer was selected based on:
|
rustbot
enabled auto-merge
September 13, 2026 23:46
rustbot
removed
the
S-waiting-on-review
rust-bors Bot
pushed a commit
to rust-lang/rust
that referenced
this pull request
Sep 16, 2026
Update cargo submodule 6 commits in 7941be6fb416b4cd9666aef7b858dfea25587a8c..30754e087c97c58c6c36d0440d4cf1aecb3330a9 2026-09-11 20:47:37 +0000 to 2026-09-15 18:19:50 +0000 - fix(git): For git cli, tell users what config we aren't forwarding on error (rust-lang/cargo#17477) - Lower the lint level of `manual_readme` and `non_kebab_case_bins` to `allow` (rust-lang/cargo#17478) - fix(trim-paths)!: unremap file in one JSON doc (rust-lang/cargo#17476) - feat(manifest): support `feature-documentation` in manifests (rust-lang/cargo#17447) - chore: Add Muscraft to the review rotation (rust-lang/cargo#17471) - Specify `--edition` in `messages` tests (rust-lang/cargo#17470) r? Urgau for the debugger script part --- 🤖 LLM disclosure: I probably should have tested this change manually, though I let LLM verify it working, sorry. Will do a manual test when I have time or if somebody beats me on that.
rust-bors Bot
pushed a commit
to rust-lang/rust
that referenced
this pull request
Sep 16, 2026
Update cargo submodule 9 commits in 7941be6fb416b4cd9666aef7b858dfea25587a8c..495c385d0875c4ba51eb72ea0448a2d4c018b8d4 2026-09-11 20:47:37 +0000 to 2026-09-16 12:48:58 +0000 - Report the number of errors with `build.warnings='deny'` (rust-lang/cargo#17479) - fix: return correct package specs when resolving workspace deps (rust-lang/cargo#17469) - refactor(config): Consolidate more config table definitions (rust-lang/cargo#17480) - fix(git): For git cli, tell users what config we aren't forwarding on error (rust-lang/cargo#17477) - Lower the lint level of `manual_readme` and `non_kebab_case_bins` to `allow` (rust-lang/cargo#17478) - fix(trim-paths)!: unremap file in one JSON doc (rust-lang/cargo#17476) - feat(manifest): support `feature-documentation` in manifests (rust-lang/cargo#17447) - chore: Add Muscraft to the review rotation (rust-lang/cargo#17471) - Specify `--edition` in `messages` tests (rust-lang/cargo#17470) r? Urgau for the debugger script part --- 🤖 LLM disclosure: I probably should have tested this change manually, though I let LLM verify it working, sorry. Will do a manual test when I have time or if somebody beats me on that.
pull Bot
pushed a commit
to LeeeeeeM/miri
that referenced
this pull request
Sep 17, 2026
Update cargo submodule 9 commits in 7941be6fb416b4cd9666aef7b858dfea25587a8c..495c385d0875c4ba51eb72ea0448a2d4c018b8d4 2026-09-11 20:47:37 +0000 to 2026-09-16 12:48:58 +0000 - Report the number of errors with `build.warnings='deny'` (rust-lang/cargo#17479) - fix: return correct package specs when resolving workspace deps (rust-lang/cargo#17469) - refactor(config): Consolidate more config table definitions (rust-lang/cargo#17480) - fix(git): For git cli, tell users what config we aren't forwarding on error (rust-lang/cargo#17477) - Lower the lint level of `manual_readme` and `non_kebab_case_bins` to `allow` (rust-lang/cargo#17478) - fix(trim-paths)!: unremap file in one JSON doc (rust-lang/cargo#17476) - feat(manifest): support `feature-documentation` in manifests (rust-lang/cargo#17447) - chore: Add Muscraft to the review rotation (rust-lang/cargo#17471) - Specify `--edition` in `messages` tests (rust-lang/cargo#17470) r? Urgau for the debugger script part --- 🤖 LLM disclosure: I probably should have tested this change manually, though I let LLM verify it working, sorry. Will do a manual test when I have time or if somebody beats me on that.
github-actions Bot
pushed a commit
to rust-lang/rustc-dev-guide
that referenced
this pull request
Sep 17, 2026
Update cargo submodule 9 commits in 7941be6fb416b4cd9666aef7b858dfea25587a8c..495c385d0875c4ba51eb72ea0448a2d4c018b8d4 2026-09-11 20:47:37 +0000 to 2026-09-16 12:48:58 +0000 - Report the number of errors with `build.warnings='deny'` (rust-lang/cargo#17479) - fix: return correct package specs when resolving workspace deps (rust-lang/cargo#17469) - refactor(config): Consolidate more config table definitions (rust-lang/cargo#17480) - fix(git): For git cli, tell users what config we aren't forwarding on error (rust-lang/cargo#17477) - Lower the lint level of `manual_readme` and `non_kebab_case_bins` to `allow` (rust-lang/cargo#17478) - fix(trim-paths)!: unremap file in one JSON doc (rust-lang/cargo#17476) - feat(manifest): support `feature-documentation` in manifests (rust-lang/cargo#17447) - chore: Add Muscraft to the review rotation (rust-lang/cargo#17471) - Specify `--edition` in `messages` tests (rust-lang/cargo#17470) r? Urgau for the debugger script part --- 🤖 LLM disclosure: I probably should have tested this change manually, though I let LLM verify it working, sorry. Will do a manual test when I have time or if somebody beats me on that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of notifying users calling bare
rustcwithout an explicit edition that they should likely be using the 2024 edition, update cargo tests to not trigger the new user facing note. This change will let rust-lang/rust#158102 to land.