Skip to content

add retries to github/gitlab repo graphql api - #3512

Merged
GuillaumeGomez merged 1 commit into
rust-lang:mainfrom
syphar:github-repo-retries
Sep 11, 2026
Merged

add retries to github/gitlab repo graphql api#3512
GuillaumeGomez merged 1 commit into
rust-lang:mainfrom
syphar:github-repo-retries

Conversation

@syphar

@syphar syphar commented Sep 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

we are seeing errors like this:

GitHub GraphQL response status: 502 Bad Gateway
<html>
<head><title>502 Bad Gateway</title></head>
<body>
<center><h1>502 Bad Gateway</h1></center>
<hr><center>nginx</center>
</body>
</html>

Where retries would likely help.

We don't retry on rate-limiting errors, what the default would be in the library we're using.
The repo-updater tasks currently run once an hour, and when we reach rate limits, we just stop updating repos and continue on the next run.

@syphar syphar self-assigned this Sep 10, 2026
@github-actions github-actions Bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Sep 10, 2026
@syphar
syphar force-pushed the github-repo-retries branch 2 times, most recently from c943b58 to b74d5a5 Compare September 10, 2026 17:48
@syphar
syphar force-pushed the github-repo-retries branch from b74d5a5 to 8509b94 Compare September 10, 2026 18:00
@syphar
syphar marked this pull request as ready for review September 10, 2026 18:00
@syphar
syphar requested a review from a team as a code owner September 10, 2026 18:00
@syphar

syphar commented Sep 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

r? @GuillaumeGomez

@rustbot rustbot assigned GuillaumeGomez and unassigned syphar Sep 10, 2026
@syphar syphar changed the title add retries to github repo graphql api add retries to github/gitlab repo graphql api Sep 11, 2026
@GuillaumeGomez

GuillaumeGomez commented Sep 11, 2026

Copy link
Copy Markdown
Member

Thanks!

@GuillaumeGomez
GuillaumeGomez merged commit a1d0fb6 into rust-lang:main Sep 11, 2026
11 checks passed
@GuillaumeGomez
GuillaumeGomez deleted the github-repo-retries branch September 11, 2026 09:27
@github-actions github-actions Bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Sep 11, 2026
@syphar syphar removed the S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it label Sep 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees

@GuillaumeGomez GuillaumeGomez

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@syphar @GuillaumeGomez