repo-stats: retry on non-standard HTTP 499 too - #3514
Merged
Merged
Conversation
github-actions
Bot
added
the
S-waiting-on-review
syphar
marked this pull request as ready for review
September 12, 2026 05:02
This comment was marked as outdated.
This comment was marked as outdated.
syphar
force-pushed
the
repo-http-499
branch
from
September 12, 2026 09:09
8c92efa to
dfb0bb2
Compare
This comment has been minimized.
This comment has been minimized.
syphar
force-pushed
the
repo-http-499
branch
from
September 12, 2026 20:06
dfb0bb2 to
0c74814
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This comment was marked as outdated.
This comment was marked as outdated.
Member
Author
GuillaumeGomez
approved these changes
Sep 14, 2026
Member
|
That one was quick to review. Weird that they have their own HTTP status code. "internet" Anyway, thanks! =D |
github-actions
Bot
added
S-waiting-on-deploy
Closed
syphar
removed
the
S-waiting-on-deploy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in sentry we see http 499 coming from github:
Some research implies it's transient (to me).
We could also have some shared retry policy where other parts of the codebase (registry-api) would also know how to handle the status 499, but for now I'll leave it just here, where I actually saw it.