use const initializer blocks for build-time & doc size metric buckets - #3534
Merged
Merged
Conversation
github-actions
Bot
added
the
S-waiting-on-review
Member
Author
GuillaumeGomez
approved these changes
Sep 17, 2026
Member
|
Readibility-wise, it's a bit less good, however the code comments explain what's going on and there is no typo issue possibility anymore (eventually logic ones). Nice work! I'll let it up to you whether you prefer this version or the previous one. In both cases you have my approval. :) |
github-actions
Bot
added
S-waiting-on-deploy
syphar
removed
the
S-waiting-on-deploy
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the comment by @GuillaumeGomez in #3533 made me think. Never used const initializer blocks, but this would work.
Question for us is if that's better readable or not :) Let's discuss :)
If that's accepted I'll revisit the other histogram bucket definitions & metrics.