Skip to content

First rust-lang/rust pull using Josh - #550

Open
Kobzol wants to merge 8 commits into
rust-lang:mainfrom
Kobzol:first-josh-pull
Open

Kobzol wants to merge 8 commits into
rust-lang:mainfrom
Kobzol:first-josh-pull

Conversation

@Kobzol

@Kobzol Kobzol commented Sep 19, 2026

Copy link
Copy Markdown
Member

Merge ref '420ed2a0c3d7' (nightly-2026-09-19) from rust-lang/rust

Pull recent changes from https://github.com/rust-lang/rust via Josh.

Previous upstream ref: rust-lang/rust@52b6e2c
New upstream ref: rust-lang/rust@420ed2a
Filtered ref: af90ba4
Upstream diff: rust-lang/rust@52b6e2c...420ed2a

This merge was created using https://github.com/rust-lang/josh-sync.

xonx4l and others added 7 commits July 25, 2026 12:41
Add intrinsic-test alias and set  sample rate



This PR adds intrinsic-test alias and set  sample rate.

It sets sample percentage to 100% .

r? @Kobzol
target_features: sse (or at least avx2) is incompatible with soft-float ABI



Fixes rust-lang/rust#117938

Enabling both the avx2 and soft-float target features is [not supported by LLVM](rust-lang/rust#117938 (comment)) and can crash the backend. Let's preempt that with rust-level checks. (I still think there's also an LLVM bug here, it shouldn't just SIGILL on unexpected target feature configurations, but that's a different discussion.)


What is not clear to me is whether this just affects just avx2 or also avx or even sse (we don't support mmx/3dnow separately).  @dianqk do you know more about this? To be safe, let's reject "sse" and therefore by implication also all other x86 vector target features.

This PR turns `#[target_feature(enable = "sse")]` on a softfloat target into an FCW similar to what we do on aarch64 (see rust-lang/rust#135160). The FCW only affects people building for soft-float targets which is a fairly small percentage of our overall users (and which means we cannot meaningfully crater this). I hence went for "report in deps" immediately so that the people building the actual binaries see these warnings that their upstreams probably will never see.
This updates the rust-toolchain.toml file to nightly-2026-09-19 (420ed2a0c3d7225b1744266fd884d431b4d8cfe0).
@rustbot

rustbot commented Sep 19, 2026

Copy link
Copy Markdown
Collaborator

⚠️ Warning ⚠️

  • The following commits have merge commits (commits with multiple parents) in your changes. We have a no merge policy so these commits will need to be removed for this pull request to be merged.

    You can start a rebase with the following commands:

    $ # rebase
    $ git pull --rebase https://github.com/rust-lang/portable-simd.git main
    $ git push --force-with-lease
    

@Kobzol Kobzol changed the title Rustc pull update First rust-lang/rust pull using Josh Sep 19, 2026
@calebzulawski

Copy link
Copy Markdown
Member

Looks like some lints etc changed with the new toolchain. What's the best way to handle this with josh? Fix on main first, or push fixes to this branch?

@Kobzol

Kobzol commented Sep 19, 2026

Copy link
Copy Markdown
Member Author

It's fine to push here. The only rule is that the Josh commits can't ever be rebased or squashed. In fact it would be good to disable rebase/squash merges in this repo altogether, if that would be fine for you.

@Kobzol

Kobzol commented Sep 21, 2026

Copy link
Copy Markdown
Member Author

error: Missing .seh_endepilogue in _RNvNtNtCsbZMQFgrTble_4libm4math6acoshf6acoshf

Ok I have no idea what to do about this one :)

@programmerjake

Copy link
Copy Markdown
Member

error: Missing .seh_endepilogue in _RNvNtNtCsbZMQFgrTble_4libm4math6acoshf6acoshf

Ok I have no idea what to do about this one :)

Created a thread on Zulip: #t-compiler/windows > Missing .seh_endepilogue in ...4libm4math6acoshf6acoshf

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants