Skip to content

feat: Resolve derive helper attributes in IDE layer - #12864

Merged
bors merged 3 commits into
rust-lang:masterfrom
Veykril:derive-helpers
Jul 26, 2022
Merged

bors merged 3 commits into
rust-lang:masterfrom
Veykril:derive-helpers

Conversation

@Veykril

@Veykril Veykril commented Jul 24, 2022 •

Copy link
Copy Markdown
Member

image

Also downmaps tokens inside deriver helpers to the derive expansion
image

This does not handle the case where multiple derives make use of the same helper name though, unsure how to tackle that yet.

Partially addresses #10935

@Veykril Veykril changed the title feat: Downmap tokens inside derive helpers feat: Record derive helper attributes, resolve them in IDE layer Jul 24, 2022
@Veykril Veykril changed the title feat: Record derive helper attributes, resolve them in IDE layer feat: Resolve derive helper attributes in IDE layer Jul 24, 2022
@bors

bors commented Jul 25, 2022

Copy link
Copy Markdown
Contributor

☔ The latest upstream changes (presumably #12871) made this pull request unmergeable. Please resolve the merge conflicts.

@Veykril
Veykril marked this pull request as ready for review July 26, 2022 07:27
@Veykril

Veykril commented Jul 26, 2022

Copy link
Copy Markdown
Member Author

@bors r+

@bors

bors commented Jul 26, 2022

Copy link
Copy Markdown
Contributor

📌 Commit ddad284 has been approved by Veykril

It is now in the queue for this repository.

@bors

bors commented Jul 26, 2022

Copy link
Copy Markdown
Contributor

⌛ Testing commit ddad284 with merge e36a20c...

@bors

bors commented Jul 26, 2022

Copy link
Copy Markdown
Contributor

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing e36a20c to master...

@bors
bors merged commit e36a20c into rust-lang:master Jul 26, 2022
@Veykril
Veykril deleted the derive-helpers branch July 26, 2022 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants