Conversation
|
r? @giraffate (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Contributor
|
r? @Alexendoo |
nyurik
force-pushed
the
fix-uninlined-fmt
branch
2 times, most recently
from
October 4, 2022 02:09
cba4ef5 to
f6c13af
Compare
Contributor
|
☔ The latest upstream changes (presumably #9547) made this pull request unmergeable. Please resolve the merge conflicts. |
nyurik
force-pushed
the
fix-uninlined-fmt
branch
from
October 4, 2022 12:47
f6c13af to
3296df4
Compare
Contributor
|
☔ The latest upstream changes (presumably #9586) made this pull request unmergeable. Please resolve the merge conflicts. |
All these tests are currently failing (generating uncompilable code). * Implement a simplified `indoc!` proc macro * added a `pass_through!(...)` macro test An edge case with format arguments being wrapped in parentesis The .fixed and .stderr were hacked without the `cargo dev bless`, so might be incorrect.
nyurik
force-pushed
the
fix-uninlined-fmt
branch
from
October 5, 2022 18:40
3296df4 to
7c3ed8d
Compare
Contributor
Author
|
these tests are no longer needed due to #9586 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All these tests are currently failing (generating uncompilable code).
indoc!proc macroprintln!("{}", (local_i32))pass_through!(...)macro testThe .fixed and .stderr were hacked without the
cargo dev bless, so might be incorrect.changelog: [
uninlined_format_args]: fixed several edge case bugsCC: @Alexendoo