-
-
Notifications
You must be signed in to change notification settings - Fork 17.3k
Blessing rmake.rs tests silently does nothing #129038
Copy link
Copy link
Closed
Labels
A-run-makeArea: port run-make Makefiles to rmake.rsArea: port run-make Makefiles to rmake.rsT-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Description
Activity
Metadata
Metadata
Assignees
Labels
A-run-makeArea: port run-make Makefiles to rmake.rsArea: port run-make Makefiles to rmake.rsT-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
While working on #129037, I noticed that running an
rmake.rstest with--blessappears to succeed, but doesn't actually update the snapshot file(s).This seems to be a side-effect of #126097. The test does successfully bless the temporary copy of the snapshot file in
build/, but that has no effect on the original snapshot file intests/run-make/.