Skip to content

Cleanup: make the self-contained path within sysroot calculation more principled #142361

Description

@jieyouxu

See #142357 (comment).

Suggestion (follow-up, not for this PR): maybe pull out a method to do the "path to sysroot target self-contained" logic.

...

I actually had a commit for that, but it's super tricky (lol). Because:

  • There are like 5 places in bootstrap that access the self-contained directory. Some of them need a relative path, some of them absolute, some of them work with a compiler, some don't, it's a mess.
  • The functions that we have in Builder for getting similar paths (invoked through the Libdir step) actually delete the directory before returning it to you 🤦 I tried to use it here and it broke everything 😂 I need to clean all of this up eventually, and move the directory clearing to a single step, so that you can get a path to something without bootstrap falling over, lol.

-- #142357 (comment)

No activity

Activity on this issue will appear here.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

C-cleanupCategory: PRs that clean code up or issues documenting cleanup.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions