Skip to content

Migrate rustc_passes diagnostics - #102110

Merged
bors merged 29 commits into
rust-lang:masterfrom
CleanCut:migrate_rustc_passes_diagnostics
Oct 12, 2022
Merged

Migrate rustc_passes diagnostics#102110
bors merged 29 commits into
rust-lang:masterfrom
CleanCut:migrate_rustc_passes_diagnostics

Conversation

@CleanCut

@CleanCut CleanCut commented Sep 21, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Picks up abandoned work from #100870

I would like to do this collaboratively, as there is a lot of work! Here's the process:

  • Comment below that you are willing to help and I will add you as a collaborator to my rust fork (that gives you write access)
  • Indicate which file/task you would like to work on (so we don't duplicate work) from the list below
  • Do the work, push up a commit, comment that you're done with that file/task
  • Repeat until done 😄

Files to Migrate (in compiler/rustc_passes/src/)

Tasks

  • Rebase on current master @CleanCut
  • Review work from the earlier PR and make sure it all looks good
    • compiler/rustc_error_messages/locales/en-US/passes.ftl @CleanCut
    • compiler/rustc_passes/src/check_attr.rs @CleanCut
    • compiler/rustc_passes/src/errors.rs @CleanCut
    • compiler/rustc_passes/src/lang_items.rs @CleanCut
    • compiler/rustc_passes/src/lib.rs @CleanCut
    • compiler/rustc_passes/src/weak_lang_items.rs @CleanCut

@rustbot rustbot added A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 21, 2022
@rust-highfive

rust-highfive commented Sep 21, 2022

Copy link
Copy Markdown
Contributor

r? @eholk

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 21, 2022
@CleanCut CleanCut changed the title Migrate rustc passes diagnostics Migrate rustc_passes diagnostics Sep 21, 2022
This was referenced Sep 21, 2022
Open
Closed
@diegooliveira

diegooliveira commented Sep 21, 2022

Copy link
Copy Markdown
Contributor

I was working on some files from the rustc_passes on this #101815.

@bors

This comment was marked as resolved.

Sign in to view
@CleanCut

CleanCut commented Sep 22, 2022

Copy link
Copy Markdown
Contributor Author

@diegooliveira Great! Should we merge those changes into this PR? Do you want to collaborate here?

@CleanCut

This comment was marked as outdated.

Sign in to view
@CleanCut

CleanCut commented Sep 23, 2022

Copy link
Copy Markdown
Contributor Author

I rebased on master again. There were lots of little conflicts to resolve.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors

This comment was marked as resolved.

Sign in to view
@CleanCut

CleanCut commented Sep 28, 2022

Copy link
Copy Markdown
Contributor Author

Rebased again to resolve new conflicts.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors

This comment was marked as resolved.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@CleanCut
CleanCut marked this pull request as ready for review October 3, 2022 03:23
@rustbot

rustbot commented Oct 3, 2022

Copy link
Copy Markdown
Collaborator

rustc_error_messages was changed

cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki

CleanCut
CleanCut commented Oct 3, 2022
View reviewed changes

@CleanCut CleanCut left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was honestly a bit brutal, especially as I ended up doing the entire thing by myself.

A couple of the errors were massive bits of code that assembled a huge, complicated error and required tons of refactoring and large custom IntoDiagnostic implementations.

Comment thread compiler/rustc_passes/src/check_attr.rs Outdated
@davidtwco

davidtwco commented Oct 3, 2022

Copy link
Copy Markdown
Member

r? @davidtwco

Nathan Stocks added 14 commits October 7, 2022 13:19
Nathan Stocks
migrate layout_test.rs to translateable diagnostics
40d5f00
Nathan Stocks
migrate lib_features.rs to translateable diagnostics
c457abe
Nathan Stocks
migrate check_const.rs to translateable diagnostics
572f341
Nathan Stocks
migrate loops.rs to translateable diagnostics
69766e4
Nathan Stocks
migrate naked_functions.rs to translateable diagnostics
96f92ea
Nathan Stocks
migrate entry.rs to translateable diagnostics
b17ec43
Nathan Stocks
migrate lang_items.rs to translateable diagnostics
f0afb88
Nathan Stocks
migrate dead.rs to translateable diagnostics
a7aa185
Nathan Stocks
migrate the rest of check_attr.rs to translateable diagnostics
3fe8e00
Nathan Stocks
migrate stability.rs to translateable diagnostics
be4059d
Nathan Stocks
First batch of review feedback changes from #102110
965dbf6
Nathan Stocks
Remove code that was removed in master, and the corresponding diagnostic
8e07a85
Nathan Stocks
avoid string dispatch in fluent
57eba4f
Nathan Stocks
avoid string dispatch in fluent
31c269a
@CleanCut

CleanCut commented Oct 9, 2022

Copy link
Copy Markdown
Contributor Author

@davidtwco Ready for a re-review.

davidtwco
davidtwco approved these changes Oct 10, 2022
View reviewed changes

@davidtwco davidtwco left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit then r=me

Comment thread compiler/rustc_passes/src/diagnostic_items.rs Outdated
@davidtwco

davidtwco commented Oct 11, 2022

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Oct 11, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit 5ef1c03 has been approved by davidtwco

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 11, 2022
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Oct 11, 2022
@Dylan-DPC
Rollup merge of rust-lang#102110 - CleanCut:migrate_rustc_passes_diag…
91509c9 
…nostics, r=davidtwco

Migrate rustc_passes diagnostics

Picks up abandoned work from rust-lang#100870

I would like to do this collaboratively, as there is a lot of work! Here's the process:

- Comment below that you are willing to help and I will add you as a collaborator to my `rust` fork (that gives you write access)
- Indicate which file/task you would like to work on (so we don't duplicate work) from the list below
- Do the work, push up a commit, comment that you're done with that file/task
- Repeat until done 😄

### Files to Migrate (in `compiler/rustc_passes/src/`)

- [x] check_attr.rs `@CleanCut`
- [x] check_const.rs `@CleanCut`
- [x] dead.rs `@CleanCut`
- [x] debugger_visualizer.rs `@CleanCut`
- [x] diagnostic_items.rs `@CleanCut`
- [x] entry.rs `@CleanCut`
- [x] lang_items.rs `@CleanCut`
- [x] layout_test.rs `@CleanCut`
- [x] lib_features.rs `@CleanCut`
- [x] ~liveness.rs~ `@CleanCut` Nothing to do
- [x] loops.rs `@CleanCut`
- [x] naked_functions.rs `@CleanCut`
- [x] stability.rs `@CleanCut`
- [x] weak_lang_items.rs `@CleanCut`

### Tasks

- [x] Rebase on current `master` `@CleanCut`
- [x] Review work from [the earlier PR](rust-lang#100870) and make sure it all looks good
  - [x] compiler/rustc_error_messages/locales/en-US/passes.ftl `@CleanCut`
  - [x] compiler/rustc_passes/src/check_attr.rs `@CleanCut`
  - [x] compiler/rustc_passes/src/errors.rs `@CleanCut`
  - [x] compiler/rustc_passes/src/lang_items.rs `@CleanCut`
  - [x] compiler/rustc_passes/src/lib.rs `@CleanCut`
  - [x] compiler/rustc_passes/src/weak_lang_items.rs `@CleanCut`
This was referenced Oct 11, 2022
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 12, 2022
@bors
Auto merge of rust-lang#102948 - Dylan-DPC:rollup-j8h74rb, r=Dylan-DPC
e6ce562 
Rollup of 8 pull requests

Successful merges:

 - rust-lang#102110 (Migrate rustc_passes diagnostics)
 - rust-lang#102187 (Use correct location for type tests in promoted constants)
 - rust-lang#102239 (Move style guide to rust-lang/rust)
 - rust-lang#102578 (Panic for invalid arguments of `{integer primitive}::ilog{,2,10}` in all modes)
 - rust-lang#102811 (Use memset to initialize readbuf)
 - rust-lang#102890 (Check representability in adt_sized_constraint)
 - rust-lang#102913 (unify `IsPattern` and `IsImport` enum in `show_candidates`)
 - rust-lang#102924 (rustdoc: remove unused classes from sidebar links)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 32471a7 into rust-lang:master Oct 12, 2022
@rustbot rustbot added this to the 1.66.0 milestone Oct 12, 2022
@Enselic Enselic mentioned this pull request Mar 10, 2023
Open
11 of 23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidtwco davidtwco davidtwco approved these changes

Assignees

@davidtwco davidtwco

Labels

A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.66.0

Development

Successfully merging this pull request may close these issues.

9 participants

@CleanCut @rust-highfive @diegooliveira @bors @rust-log-analyzer @rustbot @davidtwco @eholk @naritanara