Move IntoDiagnostic conformance for TargetDataLayoutErrors into rustc_errors

[JhonnyBillM]

Addressed this suggestion #101558 (comment).

This way we comply with the Coherence rule given that IntoDiagnostic trait is defined in rustc_errors, and almost all other crates depend on it.

[rust-highfive]

r? @eholk

(rust-highfive has picked a reviewer for you, use r? to override)

[rustbot]

rustc_error_messages was changed

cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki

[davidtwco]

Could you try this as an alternative approach?

[eholk]

@bors r? @davidtwco

@davidtwco - You seem to have more context here so I'll let you handle this PR.

[davidtwco]

LGTM, one comment to resolve then r=me

[davidtwco]

@bors r+

[bors]

📌 Commit be22157 has been approved by davidtwco

It is now in the queue for this repository.

[bors]

⌛ Testing commit be22157 with merge 1755c85...

[bors]

☀️ Test successful - checks-actions
Approved by: davidtwco
Pushing 1755c85 to master...

[rust-timer]

Finished benchmarking commit (1755c85): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean1	range	count2
Regressions ❌ (primary)	2.6%	[2.4%, 2.9%]	2
Regressions ❌ (secondary)	2.4%	[1.1%, 3.2%]	23
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.6%	[2.4%, 2.9%]	2

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean1	range	count2
Regressions ❌ (primary)	2.3%	[2.3%, 2.3%]	1
Regressions ❌ (secondary)	4.3%	[4.3%, 4.3%]	1
Improvements ✅ (primary)	-2.7%	[-4.0%, -1.4%]	2
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-1.0%	[-4.0%, 2.3%]	3

Footnotes

1. the arithmetic mean of the percent change ↩ ↩²

2. number of relevant changes ↩ ↩²