Lint against manual `impl Default` that could have been `derive`d - #134175

Closed

estebank wants to merge 26 commits into

rust-lang:masterfrom

estebank:manual-default-could-be-derive

Commits on Dec 16, 2024

Make some manual `impl Default` derived
estebank
committed
1b36289
Introduce `default_could_be_derived` lint
estebank
committed
75f1249
Use `derive(Default)`
estebank
committed
476fe03
Detect `impl Default` where fields are literals and `Default::default()` calls
estebank
committed
9b209dc
Explicitly consider fields set to `None` as `Default` derivable
estebank
committed
3ec241b
Detect when user uses default unit variant in default impl
estebank
committed
9ef798c
Use `#[derive(Default)]` for `std::option::Option`
estebank
committed
9ab4f0c
Also lint enums with type parameters with unit variant default
estebank
committed
2c7e43f
Lint against manual `Default` impl if all fields are defaulted
estebank
committed
c35fd36
Lint structs with default field values and manual `Default`
estebank
committed
e5a4a88
Extend `Default` lint to tuple-structs
estebank
committed
34ecbb9
Extend support to unit-structs and add comments
estebank
committed
e39edf7
Rework logic to make it work x-crate and remove special cases
estebank
committed
5558821
update test output
estebank
committed
da449e2
Add test for `const` "equivalent"
estebank
committed
132b49d
`#[derive(Default)] struct FixupContext`
estebank
committed
f10d560
Tweak lint output
estebank
committed
7c8b801
Split lints
estebank
committed
4c421be
Fix clippy tests
estebank
committed
64c4938
Use `derive(Default)` in rustfmt
estebank
committed
810a245
Derive `Default` in `tests::hash`
estebank
committed
448d80d
Make lint deny-by-default (for crater run)
estebank
committed
433947b
`allow(default_could_be_derived)` in `Default` examples
estebank
committed
32b933e
Mention `#[default]` in E0655 code index
estebank
committed
814146c
Fix lint example
estebank
committed
c666eae
fix rebase
estebank
committed
6fa30b6

Navigation Menu

Uh oh!

Lint against manual `impl Default` that could have been `derive`d - #134175

Lint against manual `impl Default` that could have been `derive`d#134175
estebank wants to merge 26 commits into
rust-lang:masterfrom
estebank:manual-default-could-be-derive

Commits on Dec 16, 2024

Make some manual `impl Default` derived

Introduce `default_could_be_derived` lint

Use `derive(Default)`

Detect `impl Default` where fields are literals and `Default::default()` calls

Explicitly consider fields set to `None` as `Default` derivable

Detect when user uses default unit variant in default impl

Use `#[derive(Default)]` for `std::option::Option`

Also lint enums with type parameters with unit variant default

Lint against manual `Default` impl if all fields are defaulted

Lint structs with default field values and manual `Default`

Extend `Default` lint to tuple-structs

Extend support to unit-structs and add comments

Rework logic to make it work x-crate and remove special cases

update test output

Add test for `const` "equivalent"

`#[derive(Default)] struct FixupContext`

Tweak lint output

Split lints

Fix clippy tests

Use `derive(Default)` in rustfmt

Derive `Default` in `tests::hash`

Make lint deny-by-default (for crater run)

`allow(default_could_be_derived)` in `Default` examples

Mention `#[default]` in E0655 code index

Fix lint example

fix rebase