Add methods to TCP and UDP sockets to modify hop limit (refresh of #94678) by Mallets · Pull Request #138744 · rust-lang/rust

Mallets · 2025-03-20T11:18:52Z

#94678 was closed because of time constraints of the original author (@kckeiks).

This PR is a refresh of #94678 where the original proposed changes are ported to the current status of the standard library.

In addition, this PR:

implements the change suggested in add methods to TCP and UDP sockets to modify hop limit #94678 (comment)
defines set_multicast_hop_limit_v6 and multicast_hop_limit_v6 only for UDP sockets and not for TCP sockets as originally proposed

Issue: #139166

rustbot · 2025-03-20T11:19:02Z

r? @ibraheemdev

rustbot has assigned @ibraheemdev.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

ibraheemdev · 2025-03-28T21:46:26Z

r? libs-api because it's been a while since the original PR was approved.

bors · 2025-04-13T08:05:55Z

☔ The latest upstream changes (presumably #139724) made this pull request unmergeable. Please resolve the merge conflicts.

dtolnay · 2025-04-13T16:23:19Z

Sorry—I missed that this was ready for review again. Please use @rustbot ready, which replaces S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label with S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. .

dtolnay · 2025-04-13T16:24:11Z

@rustbot ready

dtolnay · 2025-04-13T16:25:33Z

Thank you!

@bors r+

bors · 2025-04-13T16:25:35Z

📌 Commit 25fb525 has been approved by dtolnay

It is now in the queue for this repository.

…=dtolnay Add methods to TCP and UDP sockets to modify hop limit (refresh of rust-lang#94678) rust-lang#94678 was closed because of time constraints of the original author (`@kckeiks).` This PR is a refresh of rust-lang#94678 where the original proposed changes are ported to the current status of the standard library. In addition, this PR: - implements the change suggested in rust-lang#94678 (comment) - defines `set_multicast_hop_limit_v6` and `multicast_hop_limit_v6 ` only for UDP sockets and not for TCP sockets as originally proposed Issue: rust-lang#139166

Mallets · 2026-03-24T16:15:56Z

@Dylan-DPC, thank you for the reminder! I had completely overlooked this PR.
I’ve now updated it, and the CI seems to pass.

Mallets · 2026-06-29T12:56:23Z

@rustbot ready

Mallets · 2026-08-04T09:44:29Z

@dtolnay @Dylan-DPC any chances we can merge this or is there something in the way?

Co-authored-by: David Tolnay <dtolnay@gmail.com>

rustbot · 2026-08-06T14:37:17Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

Mallets · 2026-08-07T09:40:36Z

@rustbot ready

rust-bors · 2026-09-11T07:15:28Z

☔ The latest upstream changes (presumably #162622) made this pull request unmergeable. Please resolve the merge conflicts by rebasing.

clarfonthey · 2026-09-16T19:20:09Z

r? libs

Since this has a tracking issue, this should be fine to merge; just needs a rebase.

jhpratt · 2026-09-16T19:25:19Z

+    /// use std::net::TcpStream;
+    ///
+    /// let stream = TcpStream::connect("[::1]:12345")
+    ///                        .expect("Couldn't connect to the server...");


This should only be indented four spaces; I'm surprised rustfmt doesn't fail on this. Likewise on line 638.

View changes since the review

Rustfmt actually doesn't format doctests, currently. It is a bit of a weird limitation.

jhpratt · 2026-09-16T19:29:05Z

        Ok(raw as u32)
    }

+    #[cfg(not(all(target_os = "wasi", any(target_env = "p2", target_env = "p3"))))]


Let's use cfg_select! inside the body. That way if the cfg changes, it's only one place rather than multiple that need to change.

View changes since the review

jhpratt · 2026-09-16T19:40:57Z

@rustbot author

rustbot · 2026-09-16T19:41:02Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

rustbot assigned ibraheemdev Mar 20, 2025

rustbot added O-windows Operating system: Windows S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 20, 2025

Mallets mentioned this pull request Mar 20, 2025

feat: Add TTL connection param to multicast eclipse-zenoh/zenoh#1842

Merged

rustbot added the T-libs-api [DEPRECATED; DO NOT USE] label Mar 28, 2025

rustbot assigned dtolnay and unassigned ibraheemdev Mar 28, 2025

dtolnay requested changes Mar 30, 2025

View reviewed changes

Comment thread library/std/src/net/tcp.rs Outdated

Comment thread library/std/src/net/tcp.rs Outdated

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 30, 2025

Mallets mentioned this pull request Mar 31, 2025

Tracking Issue for #138744: Add methods to TCP and UDP sockets to modify IPv6 hop limits #139166

Open

4 tasks

rustbot added the has-merge-commits PR has merge commits, merge with caution. label Mar 31, 2025

This comment has been minimized.

Sign in to view

Mallets force-pushed the set_ipv6_sock_hop_limit branch from 7f790e2 to 9c1ee90 Compare March 31, 2025 10:13

rustbot removed the has-merge-commits PR has merge commits, merge with caution. label Mar 31, 2025

dtolnay force-pushed the set_ipv6_sock_hop_limit branch from 9c1ee90 to 25fb525 Compare April 13, 2025 16:23

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 13, 2025

dtolnay approved these changes Apr 13, 2025

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 13, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 29, 2026

This comment has been minimized.

Sign in to view

Mallets and others added 8 commits August 6, 2026 16:24

Add methods to TCP and UDP sockets to modify hop limit

dd43edc

Use IPv6 addresses in hop_limit_v6 docs

8827e04

Update tracking issue to 139166

867327f

Update docs according to PR review

6362319

Co-authored-by: David Tolnay <dtolnay@gmail.com>

Fix unused_variables

a258576

fix: add cfg guards on unsupported wasi p2 and p3 targets

be7a9dd

fix: tidy PAL and unsafe blocks CI failure

d7ee60c

fix: tidy CI

b0fa536

Mallets force-pushed the set_ipv6_sock_hop_limit branch from 7402270 to b0fa536 Compare August 6, 2026 14:37

This comment has been minimized.

Sign in to view

Mallets added 2 commits August 6, 2026 17:34

fix: port tests to new TCP testing framework

61fbce5

Trigger CI

32b4838

clarfonthey removed the T-libs-api [DEPRECATED; DO NOT USE] label Aug 12, 2026

rustbot assigned jhpratt and unassigned dtolnay Sep 16, 2026

jhpratt reviewed Sep 16, 2026

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 16, 2026

Uh oh!

Conversation

Mallets commented Mar 20, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Mar 20, 2025

Uh oh!

ibraheemdev commented Mar 28, 2025

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

bors commented Apr 13, 2025

Uh oh!

dtolnay commented Apr 13, 2025

Uh oh!

dtolnay commented Apr 13, 2025

Uh oh!

dtolnay commented Apr 13, 2025

Uh oh!

bors commented Apr 13, 2025

Uh oh!

Mallets commented Mar 24, 2026

Uh oh!

Mallets commented Jun 29, 2026

Uh oh!

Mallets commented Aug 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

rustbot commented Aug 6, 2026

Uh oh!

This comment has been minimized.

Mallets commented Aug 7, 2026

Uh oh!

rust-bors Bot commented Sep 11, 2026

Uh oh!

clarfonthey commented Sep 16, 2026

Uh oh!

jhpratt Sep 16, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

clarfonthey Sep 16, 2026

Choose a reason for hiding this comment

Uh oh!

jhpratt Sep 16, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jhpratt commented Sep 16, 2026

Uh oh!

rustbot commented Sep 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Mallets commented Mar 20, 2025 •

edited by rustbot

Loading

Mallets commented Aug 4, 2026 •

edited

Loading

jhpratt Sep 16, 2026 •

edited by rustbot

Loading

jhpratt Sep 16, 2026 •

edited by rustbot

Loading